Skip to content

Commit ef01c57

Browse files
committed
Toolset ruleset adjustments.
1 parent e8d95b6 commit ef01c57

File tree

1 file changed

+25
-5
lines changed

1 file changed

+25
-5
lines changed

standards/Toolset/ruleset.xml

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,21 +52,41 @@
5252
</rule>
5353

5454
<!--
55-
We allow this in JavaScript:
55+
We allow this in JavaScript or in PHP anonymous functions:
5656
5757
some_call( function( arg1, arg2 ) {
5858
...
5959
} );
6060
-->
6161
<rule ref="PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket">
62-
<exclude-pattern>*.js</exclude-pattern>
62+
<severity>0</severity>
6363
</rule>
6464
<rule ref="PEAR.Functions.FunctionCallSignature.CloseBracketLine">
65-
<exclude-pattern>*.js</exclude-pattern>
65+
<severity>0</severity>
6666
</rule>
6767
<rule ref="PEAR.Functions.FunctionCallSignature.MultipleArguments">
68-
<exclude-pattern>*.js</exclude-pattern>
68+
<severity>0</severity>
69+
</rule>
70+
71+
<!--
72+
Dear WordPress, using interpolated variables for table names is okay. ;)
73+
TODO: Adjust the rule to ignore this specific case only, if possible.
74+
-->
75+
<rule ref="WordPress.DB.PreparedSQL.NotPrepared">
76+
<severity>0</severity>
6977
</rule>
7078

79+
<!--
80+
This sniff is wreaking havoc with simple /** @var type */ comments in class properties.
81+
TODO: We need it but with some exceptions.
82+
-->
83+
<rule ref="Generic.Commenting.DocComment.MissingShort">
84+
<severity>0</severity>
85+
</rule>
86+
87+
<!-- Not always practical, e.g. if commenting on individual array items with a single word... -->
88+
<rule ref="Squiz.Commenting.InlineComment.InvalidEndChar">
89+
<severity>0</severity>
90+
</rule>
7191

72-
</ruleset>
92+
</ruleset>

0 commit comments

Comments
 (0)