Skip to content

Commit 406eb67

Browse files
authored
Merge pull request scribd#78 from zbstof/patch-1
Improve sentence structure 2020-12-14-Recycle-EKS-Worker-Nodes.md
2 parents dc9e0d2 + 43e3554 commit 406eb67

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

_posts/2020-12-14-Recycle-EKS-Worker-Nodes.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ based on events.
6767
3. Taint this "Standby" node in EKS using K8S API in [Lambda](https://github.com/scribd/terraform-aws-recycle-eks/blob/main/lambdas/taintNodes.py) to prevent new pods from getting scheduled into this node
6868
4. Periodically use K8S API check for status of “stateful” pods on that node based on the label selector provided. Another [Lambda](https://github.com/scribd/terraform-aws-recycle-eks/blob/main/lambdas/checkNodesForRunningPods.py) will do that
6969
5. Once all stateful pods have completed on the node, i.e number of running pod reached 0, shut down that standby instance using AWS SDK via [Lambda](https://github.com/scribd/terraform-aws-recycle-eks/blob/main/lambdas/detachAndTerminateNode.py).
70-
6. We are not terminating the node, only shutting it down, just in case. In future releases, we will be start terminating the nodes
70+
6. We are not terminating the node, only shutting it down, just in case. In future releases, we will start terminating the nodes
7171

7272
## Sample Execution
7373

@@ -76,11 +76,11 @@ based on events.
7676

7777
## Future Enhancements
7878

79-
1. Right now, in the first Lambda we are putting a 300 sec sleep just to ensure that the new node is in *IN* Service mode before putting the old node to StandBy mode. We have to ensure this programatically rather than an arbitrary 300 sec sleep
80-
2. Refactor the code to use as a common module for getting the access token.
79+
1. First Lambda sleeps for arbitrary 300 seconds to ensure that the new node is in *IN* Service mode before putting the old node to StandBy mode. Ensure this programatically instead of sleeping.
80+
2. Use a common module for getting the access token.
8181
3. Better logging and exception handling
8282
4. Make use of namespace input while selecting the pods. Currently it checks for pods in all namespaces.
83-
5. Find a terraform way to edit configmap/aws-auth, this step is still manual to make this module work.
83+
5. Module doesn't work without manual edit of `configmap/aws-auth`. Find a terraform way to edit it.
8484

8585
---
8686

0 commit comments

Comments
 (0)