Speed up linux process connection

cgmb · baldurk · commit c9d7c7562ca6 · 2018-02-20T16:13:08.000Z
There's no need to wait for exponential backoff to satisfy
waitTime &gt; MAX_WAIT_TIME if we already found the result.
diff --git a/renderdoc/os/posix/linux/linux_process.cpp b/renderdoc/os/posix/linux/linux_process.cpp
@@ -44,7 +44,7 @@ int GetIdentPort(pid_t childPid)
   int waitTime = INITIAL_WAIT_TIME;
 
   // try for a little while for the /proc entry to appear
-  while(waitTime <= MAX_WAIT_TIME)
+  while(ret == 0 && waitTime <= MAX_WAIT_TIME)
   {
     // back-off for each retry
     usleep(waitTime);
@@ -75,7 +75,6 @@ int GetIdentPort(pid_t childPid)
          hexport <= RenderDoc_LastTargetControlPort)
       {
         ret = hexport;
-        break;
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ int GetIdentPort(pid_t childPid)`
`44`	`44`	`int waitTime = INITIAL_WAIT_TIME;`
`45`	`45`
`46`	`46`	`// try for a little while for the /proc entry to appear`
`47`		`- while(waitTime <= MAX_WAIT_TIME)`
	`47`	`+ while(ret == 0 && waitTime <= MAX_WAIT_TIME)`
`48`	`48`	`{`
`49`	`49`	`// back-off for each retry`
`50`	`50`	`usleep(waitTime);`
`@@ -75,7 +75,6 @@ int GetIdentPort(pid_t childPid)`
`75`	`75`	`hexport <= RenderDoc_LastTargetControlPort)`
`76`	`76`	`{`
`77`	`77`	`ret = hexport;`
`78`		`- break;`
`79`	`78`	`}`
`80`	`79`	`}`
`81`	`80`