Skip to content

Commit 4240447

Browse files
committed
merge external changes
1 parent de82aee commit 4240447

File tree

7 files changed

+15
-14
lines changed

7 files changed

+15
-14
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ New [live demo](https://microsoft.github.io/PowerBI-JavaScript/demo) for sample
2323

2424
Install via Nuget:
2525

26-
`Install-Package Microsoft.PowerBI.JavaScript -Pre`
26+
`Install-Package Microsoft.PowerBI.JavaScript`
2727

2828
Install from NPM:
2929

demo/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
<script>
77
window.location = "v2-demo/index.html";
88
</script>
9-
</html>
9+
</html>

demo/v2-demo/docs.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ <h2>Getting Started</h2>
44
</div>
55
<div>
66
Please visit our
7-
<a href="https://docs.microsoft.com/en-us/azure/power-bi-embedded/power-bi-embedded-what-is-power-bi-embedded">documentation</a>
7+
<a href="https://powerbi.microsoft.com/en-us/documentation/powerbi-developer-embedding/">documentation</a>
88
to start using Power BI Embedded.
99
</div>
1010
</div>

demo/v2-demo/scripts/step_authorize.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
var reportUrl = 'http://powerbilivedemobe.azurewebsites.net/api/Reports/SampleReport';
2-
var datasetUrl = 'http://powerbilivedemobe.azurewebsites.net/api/Reports/SampleCreate';
3-
var dashboardUrl = 'http://powerbilivedemobe.azurewebsites.net/api/Dashboards/SampleDashboard';
4-
var tileUrl = 'http://powerbilivedemobe.azurewebsites.net/api/Tiles/SampleTile';
1+
var reportUrl = 'https://powerbilivedemobe.azurewebsites.net/api/Reports/SampleReport';
2+
var datasetUrl = 'https://powerbilivedemobe.azurewebsites.net/api/Reports/SampleCreate';
3+
var dashboardUrl = 'https://powerbilivedemobe.azurewebsites.net/api/Dashboards/SampleDashboard';
4+
var tileUrl = 'https://powerbilivedemobe.azurewebsites.net/api/Tiles/SampleTile';
55

66
var LastReportSampleUrl = null;
77
var ReportRefreshTokenTimer = 0;

src/factories.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export const wpmpFactory: IWpmpFactory = (name?: string, logMessages?: boolean,
2727
getTrackingProperties: hpm.HttpPostMessage.getTrackingProperties,
2828
},
2929
isErrorMessage: hpm.HttpPostMessage.isErrorMessage,
30+
suppressWarnings: true,
3031
name,
3132
logMessages,
3233
eventSourceOverrideWindow
@@ -35,4 +36,4 @@ export const wpmpFactory: IWpmpFactory = (name?: string, logMessages?: boolean,
3536

3637
export const routerFactory: IRouterFactory = (wpmp) => {
3738
return new router.Router(wpmp);
38-
};
39+
};

src/service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export class Service implements IService {
6969
/**
7070
* A list of components that this service can embed
7171
*/
72-
private static components: (typeof Report | typeof Tile | typeof Dashboard)[] = [
72+
private static components: (typeof Report | typeof Tile | typeof Dashboard)[] = [
7373
Tile,
7474
Report,
7575
Dashboard
@@ -351,8 +351,8 @@ export class Service implements IService {
351351
const iframe = element.querySelector('iframe');
352352
if (iframe) {
353353
if(iframe.remove !== undefined) {
354-
iframe.remove();
355-
}
354+
iframe.remove();
355+
}
356356
else {
357357
/** Workaround for IE: unhandled rejection TypeError: object doesn't support propert or method 'remove' */
358358
iframe.parentElement.removeChild(iframe);

tslint.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"extends": "tslint:recommended",
33
"rules": {
4-
"max-line-length": false,
4+
"max-line-length": [false],
55
"member-access": false,
6-
"no-console": false,
6+
"no-console": [false],
77
"one-line": [
88
"check-whitespace",
99
"check-open-brace"
@@ -12,7 +12,7 @@
1212
"single",
1313
"avoid-escape"
1414
],
15-
"trailing-comma": false,
15+
"trailing-comma": [false],
1616
"whitespace": [
1717
"check-branch",
1818
"check-decl",

0 commit comments

Comments
 (0)