Skip to content

CRLF causes hover calculation to not return a result #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rcjsuen opened this issue May 16, 2025 · 1 comment · Fixed by #206
Closed

CRLF causes hover calculation to not return a result #205

rcjsuen opened this issue May 16, 2025 · 1 comment · Fixed by #206
Assignees
Labels

Comments

@rcjsuen
Copy link
Collaborator

rcjsuen commented May 16, 2025

Given this textDocument/didOpen notification and the following textDocument/hover request, we are not getting any results back when we should be showing the something for container_name.

{
    "textDocument": {
        "uri": "file:///tmp/compose.crlf.yaml",
        "languageId": "dockercompose",
        "version": 47,
        "text": "services:\r\n  test:\r\n#\r\n    container_name: abc"
    }
}
{
    "textDocument": {
        "uri": "file:///tmp/compose.crlf.yaml"
    },
    "position": {
        "line": 3,
        "character": 9
    }
}
@rcjsuen rcjsuen self-assigned this May 16, 2025
@rcjsuen
Copy link
Collaborator Author

rcjsuen commented May 16, 2025

This appears to be caused by goccy/go-yaml#560.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant