Skip to content

need setting to turn docker-language-server(recommended_tag) off #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willie opened this issue Apr 29, 2025 · 6 comments
Open

need setting to turn docker-language-server(recommended_tag) off #101

willie opened this issue Apr 29, 2025 · 6 comments
Assignees

Comments

@willie
Copy link

willie commented Apr 29, 2025

I need to be able to turn off docker-language-server(recommended_tag) warning because it's recommending non LTS images and that's not how people who have specified an LTS release work.

@rcjsuen
Copy link
Collaborator

rcjsuen commented Apr 29, 2025

I need to be able to turn off docker-language-server(recommended_tag) warning because it's recommending non LTS images and that's not how people who have specified an LTS release work.

@willie Thank you for raising this. Could you share which image you are currently trying to use?

@willie
Copy link
Author

willie commented Apr 30, 2025

ubuntu:24.04

Even with a digest for 24.04 latest, it wants me to use 24.10 or 25.04.

For example:

FROM ubuntu:24.04@sha256:1e622c5f073b4f6bfad6632f2616c7f59ef256e96fe78bf6a595d1dc4376ac02

Triggers it and it's the latest 24.04 LTS image.

I filed an issue on the docker language server as well. docker/docker-language-server#121

@rcjsuen
Copy link
Collaborator

rcjsuen commented Apr 30, 2025

Thanks for sharing the finder details. We will review the data internally and see what the best path forward is.

@rcjsuen rcjsuen self-assigned this May 7, 2025
@rcjsuen
Copy link
Collaborator

rcjsuen commented May 7, 2025

@willie The current idea I have is to introduce a new setting that will let you choose what vulnerability warnings you want to see or ignore. So basically you would either make sure recommended_tag is on that list (if it is a "I want to ignore these errors" list) or in the reverse case that you could remove recommended_tag from the list (if it is a "I want to see these errors" list).

@willie
Copy link
Author

willie commented May 7, 2025

I suppose that is a good solution vs having a setting per warning, especially to work around incorrect warnings.

@davidmcl
Copy link

davidmcl commented May 8, 2025

I need to be able to turn off docker-language-server(recommended_tag) warning because it's recommending non LTS images and that's not how people who have specified an LTS release work.

Yes, please.

node:22-slim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants