Skip to content

Commit 6f48414

Browse files
authored
Address review comments in README.md
1 parent 56325a1 commit 6f48414

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

cloud_sql/postgres/pdo/README.md

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ $ ./cloud_sql_proxy \
4747

4848
### Set Configuration Values
4949

50-
Set the required environment variables for your connection to Cloud SQL. If you are using TCP mode as described above, do not set the `CLOUD_SQL_CONNECTION_NAME` variable.
50+
Set the required environment variables for your connection to Cloud SQL. If you are using Unix Socket mode as described above, do not set the DB_HOST variable.
5151

5252
```bash
5353
export DB_USER='my-db-user'
5454
export DB_PASS='my-db-pass'
5555
export DB_NAME='my-db-name'
56-
export DB_HOST='127.0.0.1'
56+
export DB_HOSTNAME='127.0.0.1'
5757
```
5858

5959
Note: Saving credentials in environment variables is convenient, but not secure - consider a more secure solution such as [Secret Manager](https://cloud.google.com/secret-manager/) to help keep secrets safe.
@@ -66,28 +66,29 @@ $ php -S localhost:8080
6666

6767
Navigate towards http://localhost:8080 to verify your application is running correctly.
6868

69-
## Google App Engine Flex
70-
71-
To run on App Engine Flex, create an App Engine project by following the setup for these [instructions](https://cloud.google.com/appengine/docs/standard/php7/quickstart#before-you-begin).
69+
## Google App Engine Standard
7270

73-
First, update `app.flex.yaml` with the correct values to pass the environment variables into the runtime.
71+
To run on App Engine Standard, create an App Engine project by following the setup for these [instructions](https://cloud.google.com/appengine/docs/standard/php7/quickstart#before-you-begin).
7472

75-
Then, make sure that the service account `service-{PROJECT_NUMBER}>@gae-api-prod.google.com.iam.gserviceaccount.com` has the IAM role `Cloud SQL Client`.
73+
First, update `app.standard.yaml` with the correct values to pass the environment variables into the runtime.
7674

7775
Next, the following command will deploy the application to your Google Cloud project:
7876

7977
```bash
80-
$ gcloud beta app deploy
78+
$ gcloud app deploy app.standard.yaml
8179
```
8280

83-
## Google App Engine Standard
81+
## Google App Engine Flex
8482

85-
To run on App Engine Standard, create an App Engine project by following the setup for these [instructions](https://cloud.google.com/appengine/docs/standard/php7/quickstart#before-you-begin).
83+
To run on App Engine Flex, create an App Engine project by following the setup for these [instructions](https://cloud.google.com/appengine/docs/standard/php7/quickstart#before-you-begin).
84+
85+
First, update `app.flex.yaml` with the correct values to pass the environment variables into the runtime.
8686

87-
First, update `app-standard.yaml` with the correct values to pass the environment variables into the runtime.
87+
Then, make sure that the service account `service-{PROJECT_NUMBER}>@gae-api-prod.google.com.iam.gserviceaccount.com` has the IAM role `Cloud SQL Client`.
8888

8989
Next, the following command will deploy the application to your Google Cloud project:
9090

9191
```bash
92-
$ gcloud app deploy app.standard.yaml
92+
$ gcloud beta app deploy app.flex.yaml
9393
```
94+

0 commit comments

Comments
 (0)