Skip to content

Commit 10edfc2

Browse files
committed
debug: hexdump arguments should be const
1 parent de9e8e0 commit 10edfc2

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

cores/esp8266/debug.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,16 @@
2121
#include "Arduino.h"
2222
#include "debug.h"
2323

24-
void ICACHE_RAM_ATTR hexdump(uint8_t *mem, uint32_t len, uint8_t cols) {
25-
os_printf("\n[HEXDUMP] Address: 0x%08X len: 0x%X (%d)", (size_t)mem, len, len);
24+
void ICACHE_RAM_ATTR hexdump(const void *mem, uint32_t len, uint8_t cols) {
25+
const uint8_t* src = (const uint8_t*) mem;
26+
os_printf("\n[HEXDUMP] Address: 0x%08X len: 0x%X (%d)", (ptrdiff_t)src, len, len);
2627
for(uint32_t i = 0; i < len; i++) {
2728
if(i % cols == 0) {
28-
os_printf("\n[0x%08X] 0x%08X: ", (size_t)mem, i);
29+
os_printf("\n[0x%08X] 0x%08X: ", (ptrdiff_t)src, i);
2930
yield();
3031
}
31-
os_printf("%02X ", *mem);
32-
mem++;
32+
os_printf("%02X ", *src);
33+
src++;
3334
}
3435
os_printf("\n");
3536
}

cores/esp8266/debug.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
#endif
1414

1515
#ifdef __cplusplus
16-
void hexdump(uint8_t *mem, uint32_t len, uint8_t cols = 16);
16+
void hexdump(const void *mem, uint32_t len, uint8_t cols = 16);
1717
#else
18-
void hexdump(uint8_t *mem, uint32_t len, uint8_t cols);
18+
void hexdump(const void *mem, uint32_t len, uint8_t cols);
1919
#endif
2020

2121
#ifdef __cplusplus

0 commit comments

Comments
 (0)