Minor clean up

Author: slandelle

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java

@@ -800,13 +800,12 @@ public Builder setValidateResponseHeaders(boolean validateResponseHeaders) {
         }
 
         public Builder setProxyServer(ProxyServer proxyServer) {
-            this.proxyServerSelector = ProxyUtils.createProxyServerSelector(proxyServer);
+            this.proxyServerSelector = uri -> proxyServer;
             return this;
         }
 
         public Builder setProxyServer(ProxyServer.Builder proxyServerBuilder) {
-            this.proxyServerSelector = ProxyUtils.createProxyServerSelector(proxyServerBuilder.build());
-            return this;
+            return setProxyServer(proxyServerBuilder.build());
         }
 
         public Builder setUseProxySelector(boolean useProxySelector) {

client/src/main/java/org/asynchttpclient/proxy/ProxyServerSelector.java

@@ -18,10 +18,5 @@ public interface ProxyServerSelector {
     /**
      * A selector that always selects no proxy.
      */
-    ProxyServerSelector NO_PROXY_SELECTOR = new ProxyServerSelector() {
-        @Override
-        public ProxyServer select(Uri uri) {
-            return null;
-        }
-    };
+    ProxyServerSelector NO_PROXY_SELECTOR = uri -> null;
 }

client/src/main/java/org/asynchttpclient/util/ProxyUtils.java

@@ -40,7 +40,7 @@
  */
 public final class ProxyUtils {
 
-    private final static Logger log = LoggerFactory.getLogger(ProxyUtils.class);
+    private final static Logger logger = LoggerFactory.getLogger(ProxyUtils.class);
 
     /**
      * The host to use as proxy.
@@ -123,7 +123,8 @@ public static ProxyServerSelector createProxyServerSelector(Properties propertie
                 proxyServer.setNonProxyHosts(new ArrayList<>(Arrays.asList(nonProxyHosts.split("\\|"))));
             }
 
-            return createProxyServerSelector(proxyServer.build());
+            ProxyServer proxy = proxyServer.build();
+            return uri -> proxy;
         }
 
         return ProxyServerSelector.NO_PROXY_SELECTOR;
@@ -157,7 +158,7 @@ public ProxyServer select(Uri uri) {
                             switch (proxy.type()) {
                             case HTTP:
                                 if (!(proxy.address() instanceof InetSocketAddress)) {
-                                    log.warn("Don't know how to connect to address " + proxy.address());
+                                    logger.warn("Don't know how to connect to address " + proxy.address());
                                     return null;
                                 } else {
                                     InetSocketAddress address = (InetSocketAddress) proxy.address();
@@ -166,31 +167,17 @@ public ProxyServer select(Uri uri) {
                             case DIRECT:
                                 return null;
                             default:
-                                log.warn("ProxySelector returned proxy type that we don't know how to use: " + proxy.type());
+                                logger.warn("ProxySelector returned proxy type that we don't know how to use: " + proxy.type());
                                 break;
                             }
                         }
                     }
                     return null;
                 } catch (URISyntaxException e) {
-                    log.warn(uri + " couldn't be turned into a java.net.URI", e);
+                    logger.warn(uri + " couldn't be turned into a java.net.URI", e);
                     return null;
                 }
             }
         };
     }
-
-    /**
-     * Create a proxy server selector that always selects a single proxy server.
-     *
-     * @param proxyServer The proxy server to select.
-     * @return The proxy server selector.
-     */
-    public static ProxyServerSelector createProxyServerSelector(final ProxyServer proxyServer) {
-        return new ProxyServerSelector() {
-            public ProxyServer select(Uri uri) {
-                return proxyServer;
-            }
-        };
-    }
 }