Skip to content

Commit 52970a2

Browse files
author
submarine-launched
authored
Merge pull request microsoft#360 from microsoft/dev/release2.10.4
Release version 2.10.4
2 parents 26312af + deda684 commit 52970a2

File tree

14 files changed

+1878
-1730
lines changed

14 files changed

+1878
-1730
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ The build and tests use webpack to compile all the source modules into one bundl
5858
## Running the demo
5959
Navigate to `/demo` directory
6060

61+
Install npm dependencies:
62+
```
63+
npm install
64+
```
65+
6166
Serve the demo directory:
6267
```
6368
npm start

demo/v2-demo/sample.html

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<div id="playground-banner" onclick="openBannerLink();">
2+
<p id="playground-banner-text">Influence the future of Power BI Embedded by joining our research panel.&nbsp;</p><p id="playground-banner-text-underlined">Sign up now!</p>
3+
<img id="playground-banner-close" src="images\close.png" onclick="closeBanner();"/>
4+
</div>
15
<div id="steps-nav-bar">
26
<div id="steps-ul-dev">
37
<ul id="steps-ul" class="steps-ul">
@@ -28,4 +32,19 @@ <h3>Welcome to the Power BI Embedded Playground</h3>
2832
</div>
2933

3034
<div id="mainContent">
31-
</div>
35+
</div>
36+
37+
<script>
38+
var showBanner = true;
39+
function closeBanner() {
40+
showBanner = false;
41+
$("#playground-banner").hide();
42+
}
43+
44+
function openBannerLink() {
45+
if (!showBanner)
46+
return;
47+
48+
window.open("https://www.usertesting.com/panels/7wZ4nzGa/join?RID=Playground", '_blank');
49+
}
50+
</script>

demo/v2-demo/scripts/codesamples.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ function _Embed_BasicEmbed_Mobile() {
111111
permissions: permissions,
112112
pageName: "ReportSectioneb8c865100f8508cc533",
113113
settings: {
114+
filterPaneEnabled: false,
114115
layoutType: models.LayoutType.MobilePortrait
115116
}
116117
};

demo/v2-demo/scripts/report.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ function OpenSamplesStep() {
3030
$("#embed-and-interact-steps-wrapper").hide();
3131

3232
$("#welcome-text").show();
33+
34+
if (window.innerWidth > 540)
35+
$("#playground-banner").show();
3336

3437
trackEvent(TelemetryEventName.InnerSectionOpen, { section: TelemetryInnerSection.Sample, src: TelemetryEventSource.UserClick });
3538
}
@@ -55,6 +58,7 @@ function OpenCodeStep(mode, entityType, tokenType) {
5558
$("#embed-and-interact-steps-wrapper").show();
5659

5760
$("#welcome-text").hide();
61+
$("#playground-banner").hide();
5862

5963
$("#highlighter").empty();
6064

demo/v2-demo/style/style.css

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1862,4 +1862,54 @@ input:checked + .slider.round {
18621862
right: calc(50% - 60px);
18631863
position: absolute;
18641864
font-size: 14px;
1865+
}
1866+
1867+
/* Playground Banner */
1868+
1869+
#playground-banner {
1870+
height: 48px;
1871+
text-align: center;
1872+
background-color: #F2C811;
1873+
padding: 12px;
1874+
border-bottom: solid 1px #F1F1F1;
1875+
cursor: pointer;
1876+
}
1877+
1878+
#playground-banner:hover {
1879+
background-color: #ddb612;
1880+
}
1881+
1882+
#playground-banner-text, #playground-banner-text-underlined {
1883+
font-size: 16px;
1884+
font-weight: 600;
1885+
display: inline-block;
1886+
}
1887+
1888+
#playground-banner-text-underlined {
1889+
text-decoration: underline;
1890+
}
1891+
1892+
#playground-banner-close {
1893+
float: right;
1894+
margin-top: 4px;
1895+
margin-right: 8px;
1896+
}
1897+
1898+
@media only screen and (max-width: 675px) {
1899+
#playground-banner-text-underlined {
1900+
display: none;
1901+
}
1902+
}
1903+
1904+
1905+
@media only screen and (max-width: 605px) {
1906+
#playground-banner-text {
1907+
font-size: 14px;
1908+
}
1909+
}
1910+
1911+
@media only screen and (max-width: 540px) {
1912+
#playground-banner {
1913+
display: none;
1914+
}
18651915
}

dist/powerbi-client.d.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! powerbi-client v2.10.3 | (c) 2016 Microsoft Corporation MIT */
1+
/*! powerbi-client v2.10.4 | (c) 2016 Microsoft Corporation MIT */
22
declare module "util" {
33
import { HttpPostMessage } from 'http-post-message';
44
/**
@@ -77,10 +77,18 @@ declare module "util" {
7777
* Checks if the embed url is for RDL report.
7878
*
7979
* @export
80-
* @param {string} embedUrl
81-
* @returns {boolean}
80+
* @param {string} embedUrl
81+
* @returns {boolean}
8282
*/
8383
export function isRDLEmbed(embedUrl: string): boolean;
84+
/**
85+
* Checks if the embed url contains autoAuth=true.
86+
*
87+
* @export
88+
* @param {string} embedUrl
89+
* @returns {boolean}
90+
*/
91+
export function autoAuthInEmbedUrl(embedUrl: string): boolean;
8492
/**
8593
* Returns random number
8694
*/
@@ -100,6 +108,10 @@ declare module "defaults" {
100108
static defaultQnaSettings: models.IQnaSettings;
101109
}
102110
}
111+
declare module "errors" {
112+
export let APINotSupportedForRDLError: string;
113+
export let EmbedUrlNotSupported: string;
114+
}
103115
declare module "embed" {
104116
import * as service from "service";
105117
import * as models from 'powerbi-models';
@@ -495,9 +507,6 @@ declare module "embed" {
495507
private frontLoadSendConfig(config);
496508
}
497509
}
498-
declare module "errors" {
499-
export let APINotSupportedForRDLError: string;
500-
}
501510
declare module "ifilterable" {
502511
import * as models from 'powerbi-models';
503512
/**

0 commit comments

Comments
 (0)