Skip to content

Commit 771acc7

Browse files
computersforpeacetorvalds
authored andcommitted
Bluetooth: btusb: request wake pin with NOAUTOEN
Badly-designed systems might have (for example) active-high wake pins that default to high (e.g., because of external pull ups) until they have an active firmware which starts driving it low. This can cause an interrupt storm in the time between request_irq() and disable_irq(). We don't support shared interrupts here, so let's just pre-configure the interrupt to avoid auto-enabling it. Fixes: fd913ef ("Bluetooth: btusb: Add out-of-band wakeup support") Fixes: 5364a0b ("arm64: dts: rockchip: move QCA6174A wakeup pin into its USB node") Signed-off-by: Brian Norris <[email protected]> Reviewed-by: Matthias Kaehlcke <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 0ee7fb3 commit 771acc7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/bluetooth/btusb.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -2942,6 +2942,7 @@ static int btusb_config_oob_wake(struct hci_dev *hdev)
29422942
return 0;
29432943
}
29442944

2945+
irq_set_status_flags(irq, IRQ_NOAUTOEN);
29452946
ret = devm_request_irq(&hdev->dev, irq, btusb_oob_wake_handler,
29462947
0, "OOB Wake-on-BT", data);
29472948
if (ret) {
@@ -2956,7 +2957,6 @@ static int btusb_config_oob_wake(struct hci_dev *hdev)
29562957
}
29572958

29582959
data->oob_wake_irq = irq;
2959-
disable_irq(irq);
29602960
bt_dev_info(hdev, "OOB Wake-on-BT configured at IRQ %u", irq);
29612961
return 0;
29622962
}

0 commit comments

Comments
 (0)