test & fix lowercase method name triggers destroy session

Author: daaku

src/base_facebook.php

@@ -754,8 +754,9 @@ protected function _restserver($params) {
       $this->throwAPIException($result);
     }
 
-    if ($params['method'] === 'auth.expireSession' ||
-        $params['method'] === 'auth.revokeAuthorization') {
+    $method = strtolower($params['method']);
+    if ($method === 'auth.expiresession' ||
+        $method === 'auth.revokeauthorization') {
       $this->destroySession();
     }
 

tests/tests.php

@@ -1306,6 +1306,32 @@ public function testAuthExpireSessionDestroysSession() {
     );
   }
 
+  public function testLowercaseAuthRevokeAuthDestroysSession() {
+    $methods_to_stub = array(
+      '_oauthRequest',
+      'destroySession',
+    );
+    $constructor_args = array(array(
+      'appId'  => self::APP_ID,
+      'secret' => self::SECRET
+    ));
+    $key = 'foo';
+    $val = 42;
+    $stub = $this->getMock(
+      'TransientFacebook', $methods_to_stub, $constructor_args);
+    $stub
+      ->expects($this->once())
+      ->method('_oauthRequest')
+      ->will($this->returnValue("{\"$key\":$val}"));
+    $stub
+      ->expects($this->once())
+      ->method('destroySession');
+    $this->assertEquals(
+      array($key => $val),
+      $stub->api(array('method' => 'auth.revokeauthorization'))
+    );
+  }
+
   protected function generateMD5HashOfRandomValue() {
     return md5(uniqid(mt_rand(), true));
   }