Skip to content

Commit ff466dc

Browse files
committed
RxScala: Switch mapped RxJava methods to map to non-deprecated versions
- Mark onErrorFlatMap/from(Iterable, Scheduler) as deprecated, since the RxJava version will go away
1 parent 4e41693 commit ff466dc

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Observable.scala

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ trait Observable[+T]
410410
*/
411411
def zipWith[U, R](that: Iterable[U])(selector: (T, U) => R): Observable[R] = {
412412
val thisJava = asJavaObservable.asInstanceOf[rx.Observable[T]]
413-
toScalaObservable[R](thisJava.zip(that.asJava, selector))
413+
toScalaObservable[R](thisJava.zipWith(that.asJava, selector))
414414
}
415415

416416
/**
@@ -933,7 +933,7 @@ trait Observable[+T]
933933
val jOnCompleted = new Func0[rx.Observable[_ <: R]] {
934934
override def call(): rx.Observable[_ <: R] = onCompleted().asJavaObservable
935935
}
936-
toScalaObservable[R](asJavaObservable.mergeMap[R](jOnNext, jOnError, jOnCompleted))
936+
toScalaObservable[R](asJavaObservable.flatMap[R](jOnNext, jOnError, jOnCompleted))
937937
}
938938

939939
/**
@@ -954,7 +954,7 @@ trait Observable[+T]
954954
val jCollectionSelector = new Func1[T, rx.Observable[_ <: U]] {
955955
override def call(t: T): rx.Observable[_ <: U] = collectionSelector(t).asJavaObservable
956956
}
957-
toScalaObservable[R](asJavaObservable.mergeMap[U, R](jCollectionSelector, resultSelector))
957+
toScalaObservable[R](asJavaObservable.flatMap[U, R](jCollectionSelector, resultSelector))
958958
}
959959

960960
/**
@@ -973,7 +973,7 @@ trait Observable[+T]
973973
val jCollectionSelector = new Func1[T, java.lang.Iterable[_ <: R]] {
974974
override def call(t: T): java.lang.Iterable[_ <: R] = collectionSelector(t).asJava
975975
}
976-
toScalaObservable[R](asJavaObservable.mergeMapIterable[R](jCollectionSelector))
976+
toScalaObservable[R](asJavaObservable.flatMapIterable[R](jCollectionSelector))
977977
}
978978

979979
/**
@@ -994,7 +994,7 @@ trait Observable[+T]
994994
val jCollectionSelector = new Func1[T, java.lang.Iterable[_ <: U]] {
995995
override def call(t: T): java.lang.Iterable[_ <: U] = collectionSelector(t).asJava
996996
}
997-
toScalaObservable[R](asJavaObservable.mergeMapIterable[U, R](jCollectionSelector, resultSelector))
997+
toScalaObservable[R](asJavaObservable.flatMapIterable[U, R](jCollectionSelector, resultSelector))
998998
}
999999

10001000
/**
@@ -1227,6 +1227,7 @@ trait Observable[+T]
12271227
* will be `None`.
12281228
* @return the original Observable, with appropriately modified behavior
12291229
*/
1230+
@Deprecated
12301231
def onErrorFlatMap[U >: T](resumeFunction: (Throwable, Option[Any]) => Observable[U]): Observable[U] = {
12311232
val f = new Func1[rx.exceptions.OnErrorThrowable, rx.Observable[_ <: U]] {
12321233
override def call(t: rx.exceptions.OnErrorThrowable): rx.Observable[_ <: U] = {
@@ -4482,6 +4483,7 @@ object Observable {
44824483
* @return an Observable that emits each item in the source `Iterable`
44834484
* sequence
44844485
*/
4486+
@deprecated("Use `from(Iterable).subscribeOn` instead", "0.20")
44854487
def from[T](iterable: Iterable[T], scheduler: Scheduler): Observable[T] = {
44864488
toScalaObservable(rx.Observable.from(iterable.asJava, scheduler.asJavaScheduler))
44874489
}

language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/ObservableTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class ObservableTests extends JUnitSuite {
7171
// If this changes (i.e. it suppresses errors and returns default) then Scala's firstOrElse
7272
// should be changed accordingly.
7373
@Test def testJavaFirstOrDefault() {
74-
assertEquals(1, rx.Observable.from(1, 2).firstOrDefault(10).toBlocking().single)
74+
assertEquals(1, rx.Observable.just(1, 2).firstOrDefault(10).toBlocking().single)
7575
assertEquals(10, rx.Observable.empty().firstOrDefault(10).toBlocking().single)
7676
val msg = "msg6251"
7777
var receivedMsg = "none"

0 commit comments

Comments
 (0)