Add new rules on eslint linter and adapt source code

Author: ganatan

frontend/.eslintrc.json

@@ -19,6 +19,13 @@
         "plugin:@angular-eslint/template/process-inline-templates"
       ],
       "rules": {
+        "no-var": "error",
+        "prefer-const": "error",
+        "func-names": "error",
+        "id-length": "error",
+        "newline-before-return": "error",
+        "space-before-blocks": "error",
+        "no-alert": "error",
         "@angular-eslint/directive-selector": [
           "error",
           {

frontend/src/app/modules/application/angular/angular.component.ts

@@ -95,11 +95,11 @@ export class AngularComponent implements OnInit {
   loadScript(name: string): void {
 
     if (isPlatformBrowser(this.platformId)) {
-      const s = document.createElement('script');
-      s.type = 'text/javascript';
-      s.src = name;
-      s.async = false;
-      document.getElementsByTagName('head')[0].appendChild(s);
+      const src = document.createElement('script');
+      src.type = 'text/javascript';
+      src.src = name;
+      src.async = false;
+      document.getElementsByTagName('head')[0].appendChild(src);
     }
   }
 

frontend/src/app/modules/application/boxoffice/boxoffice.component.ts

@@ -7,7 +7,7 @@ import { ItemsService } from './items/items.service';
 import { environment } from '../../../../environments/environment';
 
 
-declare var bootstrap: any;
+declare const bootstrap: any;
 
 @Component({
   selector: 'app-boxoffice',
@@ -70,7 +70,7 @@ export class BoxofficeComponent implements OnInit {
   }
 
   formFilterChanged(data: any) {
-    let shows = data["shows"];
+    const shows = data["shows"];
   };
 
   getItems(): any {
@@ -91,7 +91,7 @@ export class BoxofficeComponent implements OnInit {
       this.modalPlayer = new bootstrap.Modal(document.getElementById('exampleModal'), {
         keyboard: true
       })
-      let selectPlayer = document.getElementById('exampleModal')
+      const selectPlayer = document.getElementById('exampleModal')
       selectPlayer?.addEventListener('show.bs.modal', this.onShowModal.bind(this));
       selectPlayer?.addEventListener('hidden.bs.modal', this.onCloseModal.bind(this));
     }

frontend/src/app/modules/application/boxoffice/items/items.service.ts

@@ -23,6 +23,7 @@ export class ItemsService {
     return (error: any): Observable<T> => {
       console.error(error);
       this.log(`${operation} failed: ${error.message}`);
+
       return of(result as T);
     };
   }

frontend/src/app/modules/application/example-bootstrap/collapses/items.component.ts

@@ -1,6 +1,6 @@
 import { Component, OnInit } from '@angular/core';
 
-declare var bootstrap: any;
+declare const bootstrap: any;
 
 @Component({
   selector: 'app-collapse',
@@ -13,22 +13,22 @@ export class CollapsesComponent {
 
 
   closeCollapse() {
-    var myCollapse = document.getElementById('collapseWidthJavascript')
-    var bsCollapse = new bootstrap.Collapse(myCollapse, {
+    const myCollapse = document.getElementById('collapseWidthJavascript')
+    const bsCollapse = new bootstrap.Collapse(myCollapse, {
       hide: true,
     })
   }
 
   showCollapse() {
-    var myCollapse = document.getElementById('collapseWidthJavascript')
-    var bsCollapse = new bootstrap.Collapse(myCollapse, {
+    const myCollapse = document.getElementById('collapseWidthJavascript')
+    const bsCollapse = new bootstrap.Collapse(myCollapse, {
       show: true,
     })
   }
 
   toggleCollapse() {
-    var myCollapse = document.getElementById('collapseWidthJavascript')
-    var bsCollapse = new bootstrap.Collapse(myCollapse, {
+    const myCollapse = document.getElementById('collapseWidthJavascript')
+    const bsCollapse = new bootstrap.Collapse(myCollapse, {
       toggle: true,
     })
   }

frontend/src/app/modules/application/example-bootstrap/popovers/items.component.ts

@@ -14,11 +14,11 @@ export class PopoversComponent implements OnInit {
   }
 
   loadScript(name: string): void {
-    const s = document.createElement('script');
-    s.type = 'text/javascript';
-    s.src = name;
-    s.async = false;
-    document.getElementsByTagName('head')[0].appendChild(s);
+    const src = document.createElement('script');
+    src.type = 'text/javascript';
+    src.src = name;
+    src.async = false;
+    document.getElementsByTagName('head')[0].appendChild(src);
   }
 
 }

frontend/src/app/modules/application/example-bootstrap/toasts/items.component.ts

@@ -14,11 +14,11 @@ export class ToastsComponent implements OnInit {
   }
 
   loadScript(name: string): void {
-    const s = document.createElement('script');
-    s.type = 'text/javascript';
-    s.src = name;
-    s.async = false;
-    document.getElementsByTagName('head')[0].appendChild(s);
+    const src = document.createElement('script');
+    src.type = 'text/javascript';
+    src.src = name;
+    src.async = false;
+    document.getElementsByTagName('head')[0].appendChild(src);
   }
 
 }

frontend/src/app/modules/application/example-bootstrap/tooltips/items.component.ts

@@ -14,11 +14,11 @@ export class TooltipsComponent implements OnInit {
   }
 
   loadScript(name: string): void {
-    const s = document.createElement('script');
-    s.type = 'text/javascript';
-    s.src = name;
-    s.async = false;
-    document.getElementsByTagName('head')[0].appendChild(s);
+    const src = document.createElement('script');
+    src.type = 'text/javascript';
+    src.src = name;
+    src.async = false;
+    document.getElementsByTagName('head')[0].appendChild(src);
   }
 
 }

frontend/src/app/modules/application/example-crud/components/page-list/page-list.component.ts

@@ -63,12 +63,12 @@ export class PageListComponent {
   readQueryParams(): void {
     this.route.queryParams
       .subscribe(params => {
-        this.params.q = params['q'];
+        this.params.query = params['q'];
         if (params['page'] !== undefined) {
           this.params.page = params['page'];
           this.itemsPage = parseInt(this.params.page, 10);
         }
-        this.searchField = this.params.q;
+        this.searchField = this.params.query;
         this.getItems();
       });
   }
@@ -108,7 +108,7 @@ export class PageListComponent {
     if (this.itemsPage > 1) {
       page = this.itemsPage.toString();
     }
-    this.params.q = query;
+    this.params.query = query;
     this.params.page = page;
     this.router.navigate(['crud/' + url], { queryParams: this.params });
   }

frontend/src/app/modules/application/example-crud/components/page-list/params.ts

@@ -1,10 +1,10 @@
 export class Params {
 
-  public q: string;
+  public query: string;
   public page: string;
 
   constructor() { 
-    this.q = '';
+    this.query = '';
     this.page = '';
   }