Fix WiFi::setHostname

Author: me-no-dev

libraries/WiFi/src/WiFiGeneric.cpp

@@ -800,7 +800,6 @@ esp_err_t WiFiGenericClass::_eventCallback(arduino_event_t *event)
     } else if(event->event_id == ARDUINO_EVENT_WIFI_STA_START) {
         WiFiSTAClass::_setStatus(WL_DISCONNECTED);
         setStatusBits(STA_STARTED_BIT);
-        tcpip_adapter_set_hostname(TCPIP_ADAPTER_IF_STA, WiFiSTAClass::_hostname.c_str());
         if(esp_wifi_set_ps(_sleepEnabled) != ESP_OK){
             log_e("esp_wifi_set_ps failed");
         }

libraries/WiFi/src/WiFiGeneric.h

@@ -172,6 +172,7 @@ class WiFiGenericClass
 
     static const char * getHostname();
     static bool setHostname(const char * hostname);
+    static bool hostname(const String& aHostname) { return setHostname(aHostname.c_str()); }
 
     static esp_err_t _eventCallback(arduino_event_t *event);
 

libraries/WiFi/src/WiFiSTA.cpp

@@ -104,7 +104,6 @@ static void wifi_sta_config(wifi_config_t * wifi_config, const char * ssid=NULL,
 
 bool WiFiSTAClass::_autoReconnect = true;
 bool WiFiSTAClass::_useStaticIp = false;
-String WiFiSTAClass::_hostname = "esp32-arduino";
 
 static wl_status_t _sta_status = WL_NO_SHIELD;
 static EventGroupHandle_t _sta_status_group = NULL;
@@ -614,36 +613,6 @@ int8_t WiFiSTAClass::RSSI(void)
     return 0;
 }
 
-/**
- * Get the station interface Host name.
- * @return char array hostname
- */
-const char * WiFiSTAClass::getHostname()
-{
-    const char * hostname = NULL;
-    if(WiFiGenericClass::getMode() == WIFI_MODE_NULL){
-        return hostname;
-    }
-    if(tcpip_adapter_get_hostname(TCPIP_ADAPTER_IF_STA, &hostname)){
-        return NULL;
-    }
-    return hostname;
-}
-
-/**
- * Set the station interface Host name.
- * @param  hostname  pointer to const string
- * @return true on   success
- */
-bool WiFiSTAClass::setHostname(const char * hostname)
-{
-    _hostname = hostname;
-    if(WiFiGenericClass::getMode() == WIFI_MODE_NULL){
-        return false;
-    }
-    return tcpip_adapter_set_hostname(TCPIP_ADAPTER_IF_STA, hostname) == 0;
-}
-
 /**
  * Enable IPv6 on the station interface.
  * @return true on success

libraries/WiFi/src/WiFiSTA.h

@@ -75,10 +75,6 @@ class WiFiSTAClass
     bool enableIpV6();
     IPv6Address localIPv6();
 
-    const char * getHostname();
-    bool setHostname(const char * hostname);
-    bool hostname(const String& aHostname) { return setHostname(aHostname.c_str()); }
-
     // STA WiFi info
     static wl_status_t status();
     String SSID() const;
@@ -90,7 +86,7 @@ class WiFiSTAClass
     int8_t RSSI();
 
     static void _setStatus(wl_status_t status);
-    static String _hostname;
+    
 protected:
     static bool _useStaticIp;
     static bool _autoReconnect;