Skip to content

Commit 2f9b776

Browse files
committed
Merge pull request angular-fullstack#1400 from DaftMonk/node-4.2.1
support node 4.2.2
2 parents c184087 + 3ae64d7 commit 2f9b776

File tree

12 files changed

+24
-18
lines changed

12 files changed

+24
-18
lines changed

.travis.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
sudo: false
22
language: node_js
33
node_js:
4-
- '0.12'
5-
- '4.0.0'
4+
- 4.2.2
65
env:
76
global:
87
- SAUCE_USERNAME=fullstack_ci
98
- SAUCE_ACCESS_KEY=1a527ca6-4aa5-4618-86ce-0278bf158cbf
109
matrix:
1110
fast_finish: true
1211
allow_failures:
13-
- node_js: 4.0.0
12+
- node_js: 5.0.0
1413
before_install:
1514
- ./scripts/sauce_connect_setup.sh
1615
- gem update --system

Gruntfile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,8 @@ module.exports = function (grunt) {
292292
child_process.exec('bower install', {cwd: '../fixtures'}, function (error, stdout, stderr) {
293293

294294
if(!process.env.SAUCE_USERNAME) {
295-
grunt.log.ok('running npm run update-webdriver');
296-
child_process.exec('npm run update-webdriver', function() {
295+
grunt.log.ok('running npm run-script update-webdriver');
296+
child_process.exec('npm run-script update-webdriver', function() {
297297
shell.cd('../../');
298298
done();
299299
});

app/templates/.jscsrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
{
2+
"excludeFiles": [
3+
"client/app/app.constant.js"
4+
],
25
"esnext": true,
36
"maximumLineLength": {
47
"value": 100,

app/templates/.travis.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
language: node_js
22
node_js:
3-
- '0.12'
4-
- '4.0.0'
3+
- 4.2.2
54
matrix:
65
fast_finish: true
76
allow_failures:
8-
- node_js: 4.0.0
7+
- node_js: 5.0.0
98
before_script:
109
- npm install -g bower grunt-cli<% if (filters.sass) { %>
1110
- gem install sass<% } %>

app/templates/_package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"grunt-nodemon": "^0.4.0",
6767
"grunt-angular-templates": "^0.5.4",
6868
"grunt-dom-munger": "^3.4.0",
69-
"grunt-protractor-runner": "^2.0.0",
69+
"grunt-protractor-runner": "https://github.com/StoutLLC/grunt-protractor-runner",
7070
"grunt-injector": "^0.6.0",
7171
"grunt-karma": "~0.12.0",
7272
"grunt-build-control": "^0.6.0",<% if(filters.sass) { %>
@@ -111,7 +111,8 @@
111111
"supertest": "^1.1.0"
112112
},
113113
"engines": {
114-
"node": ">=0.12.0"
114+
"node": "^4.2.2",
115+
"npm": "^2.14.7"
115116
},
116117
"scripts": {
117118
"start": "node server",

app/templates/e2e/account(auth)/login/login.po.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var LoginPage = function() {
2020
}
2121
}
2222

23-
form.submit.click();
23+
return form.submit.click();
2424
};
2525
};
2626

app/templates/e2e/account(auth)/login/login.spec(mocha).js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ describe('Login View', function() {
88
var page;
99

1010
var loadPage = function() {
11-
browser.get(config.baseUrl + '/login');
11+
let promise = browser.get(config.baseUrl + '/login');
1212
page = require('./login.po');
13+
return promise;
1314
};
1415

1516
var testUser = {

app/templates/e2e/account(auth)/logout/logout.spec(mocha).js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ var UserModel = require(config.serverConfig.root + '/server/sqldb').User;<% } %>
66

77
describe('Logout View', function() {
88
var login = function(user) {
9-
browser.get(config.baseUrl + '/login');
9+
let promise = browser.get(config.baseUrl + '/login');
1010
require('../login/login.po').login(user);
11+
return promise;
1112
};
1213

1314
var testUser = {

app/templates/e2e/account(auth)/signup/signup.po.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ var SignupPage = function() {
2222
}
2323
}
2424

25-
form.submit.click();
25+
return form.submit.click();
2626
};
2727
};
2828

app/templates/e2e/account(auth)/signup/signup.spec(mocha).js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ describe('Signup View', function() {
99

1010
var loadPage = function() {
1111
browser.manage().deleteAllCookies()
12-
browser.get(config.baseUrl + '/signup');
12+
let promise = browser.get(config.baseUrl + '/signup');
1313
page = require('./signup.po');
14+
return promise;
1415
};
1516

1617
var testUser = {

0 commit comments

Comments
 (0)