Skip to content

Commit 33d645d

Browse files
authored
adds memcache mocks for pubsub tests (GoogleCloudPlatform#167)
1 parent 23cdf02 commit 33d645d

File tree

4 files changed

+125
-21
lines changed

4 files changed

+125
-21
lines changed

pubsub/app/app.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,21 +83,23 @@
8383
});
8484

8585
$app['get_pull_messages'] = $app->protect(function ($clearMessages = false) {
86-
$memcache = new Memcached;
87-
if ($pullMessages = $memcache->get('pull-messages')) {
86+
if ($pullMessages = $app['memcache']->get('pull-messages')) {
8887
if ($clearMessages) {
89-
$memcache->set('pull-messages', []);
88+
$app['memcache']->set('pull-messages', []);
9089
}
9190
return $pullMessages;
9291
}
9392
return [];
9493
});
9594

9695
$app['save_pull_message'] = $app->protect(function ($message) use ($app) {
97-
$memcache = new Memcached;
9896
$messages = $app['get_pull_messages']();
9997
$messages[] = $message;
100-
$memcache->set('pull-messages', $messages);
98+
$app['memcache']->set('pull-messages', $messages);
10199
});
102100

101+
$app['memcache'] = function () {
102+
return new Memcached;
103+
};
104+
103105
return $app;

pubsub/app/composer.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@
88
},
99
"require-dev": {
1010
"google/cloud-tools": "<=1.0",
11+
"gecko-packages/gecko-memcache-mock": "^2.0",
1112
"paragonie/random_compat": "^2.0",
1213
"symfony/browser-kit": "~2.7",
1314
"symfony/css-selector": "~2.0",
1415
"symfony/dom-crawler": "~2.0",
15-
"symfony/yaml": "^3.1"
16+
"symfony/yaml": "^3.1",
17+
"phpunit/phpunit": " ~4.1"
1618
}
1719
}

pubsub/app/composer.lock

Lines changed: 112 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pubsub/app/test/appTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
use Silex\WebTestCase;
2121
use Symfony\Component\HttpKernel\Client;
22+
use GeckoPackages\MemcacheMock\MemcachedMock;
2223

2324
class appTest extends WebTestCase
2425
{
@@ -32,6 +33,8 @@ public function createApplication()
3233
$app['project_id'] = 'cloud-samples-tests-php';
3334
$app['topic'] = getenv('GOOGLE_PUBSUB_TOPIC');
3435
$app['subscription'] = getenv('GOOGLE_PUBSUB_SUBSCRIPTION');
36+
$app['memcache'] = new MemcachedMock;
37+
$app['memcache']->addServer("localhost", 11211);
3538

3639
// this will be set by travis, but may not be set locally
3740
if (!$credentials = getenv('GOOGLE_APPLICATION_CREDENTIALS')) {

0 commit comments

Comments
 (0)