Skip to content

Commit b43989b

Browse files
committed
Merge pull request opencv#7303 from K-Shinotsuka:issue18
2 parents 17f0c93 + 37be868 commit b43989b

File tree

1 file changed

+25
-47
lines changed

1 file changed

+25
-47
lines changed

modules/imgproc/src/color.cpp

Lines changed: 25 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -5872,38 +5872,33 @@ struct RGB2Luv_b
58725872
#elif CV_SSE2
58735873
v_zero = _mm_setzero_si128();
58745874
v_scale_inv = _mm_set1_ps(1.f/255.f);
5875-
v_scale = _mm_set1_ps(2.55f);
5876-
v_coeff1 = _mm_set1_ps(0.72033898305084743f);
5877-
v_coeff2 = _mm_set1_ps(96.525423728813564f);
5878-
v_coeff3 = _mm_set1_ps(0.9732824427480916f);
5879-
v_coeff4 = _mm_set1_ps(136.259541984732824f);
58805875
haveSIMD = checkHardwareSupport(CV_CPU_SSE2);
58815876
#endif
58825877
}
58835878

58845879
#if CV_SSE2
58855880
void process(const float * buf,
5886-
__m128i & v_l, __m128i & v_u, __m128i & v_v) const
5881+
__m128 & v_coeffs, __m128 & v_res, uchar * dst) const
58875882
{
58885883
__m128 v_l0f = _mm_load_ps(buf);
58895884
__m128 v_l1f = _mm_load_ps(buf + 4);
58905885
__m128 v_u0f = _mm_load_ps(buf + 8);
58915886
__m128 v_u1f = _mm_load_ps(buf + 12);
5892-
__m128 v_v0f = _mm_load_ps(buf + 16);
5893-
__m128 v_v1f = _mm_load_ps(buf + 20);
58945887

5895-
_mm_deinterleave_ps(v_l0f, v_l1f, v_u0f, v_u1f, v_v0f, v_v1f);
5888+
v_l0f = _mm_add_ps(_mm_mul_ps(v_l0f, v_coeffs), v_res);
5889+
v_u1f = _mm_add_ps(_mm_mul_ps(v_u1f, v_coeffs), v_res);
5890+
v_coeffs = _mm_castsi128_ps(_mm_shuffle_epi32(_mm_castps_si128(v_coeffs), 0x92));
5891+
v_res = _mm_castsi128_ps(_mm_shuffle_epi32(_mm_castps_si128(v_res), 0x92));
5892+
v_u0f = _mm_add_ps(_mm_mul_ps(v_u0f, v_coeffs), v_res);
5893+
v_coeffs = _mm_castsi128_ps(_mm_shuffle_epi32(_mm_castps_si128(v_coeffs), 0x92));
5894+
v_res = _mm_castsi128_ps(_mm_shuffle_epi32(_mm_castps_si128(v_res), 0x92));
5895+
v_l1f = _mm_add_ps(_mm_mul_ps(v_l1f, v_coeffs), v_res);
58965896

5897-
v_l0f = _mm_mul_ps(v_l0f, v_scale);
5898-
v_l1f = _mm_mul_ps(v_l1f, v_scale);
5899-
v_u0f = _mm_add_ps(_mm_mul_ps(v_u0f, v_coeff1), v_coeff2);
5900-
v_u1f = _mm_add_ps(_mm_mul_ps(v_u1f, v_coeff1), v_coeff2);
5901-
v_v0f = _mm_add_ps(_mm_mul_ps(v_v0f, v_coeff3), v_coeff4);
5902-
v_v1f = _mm_add_ps(_mm_mul_ps(v_v1f, v_coeff3), v_coeff4);
5897+
__m128i v_l = _mm_packs_epi32(_mm_cvtps_epi32(v_l0f), _mm_cvtps_epi32(v_l1f));
5898+
__m128i v_u = _mm_packs_epi32(_mm_cvtps_epi32(v_u0f), _mm_cvtps_epi32(v_u1f));
5899+
__m128i v_l0 = _mm_packus_epi16(v_l, v_u);
59035900

5904-
v_l = _mm_packs_epi32(_mm_cvtps_epi32(v_l0f), _mm_cvtps_epi32(v_l1f));
5905-
v_u = _mm_packs_epi32(_mm_cvtps_epi32(v_u0f), _mm_cvtps_epi32(v_u1f));
5906-
v_v = _mm_packs_epi32(_mm_cvtps_epi32(v_v0f), _mm_cvtps_epi32(v_v1f));
5901+
_mm_storeu_si128((__m128i *)(dst), v_l0);
59075902
}
59085903
#endif
59095904

@@ -5912,6 +5907,11 @@ struct RGB2Luv_b
59125907
int i, j, scn = srccn;
59135908
float CV_DECL_ALIGNED(16) buf[3*BLOCK_SIZE];
59145909

5910+
#if CV_SSE2
5911+
__m128 v_coeffs = _mm_set_ps(2.55f, 0.9732824427480916f, 0.72033898305084743f, 2.55f);
5912+
__m128 v_res = _mm_set_ps(0.f, 136.259541984732824f, 96.525423728813564f, 0.f);
5913+
#endif
5914+
59155915
for( i = 0; i < n; i += BLOCK_SIZE, dst += BLOCK_SIZE*3 )
59165916
{
59175917
int dn = std::min(n - i, (int)BLOCK_SIZE);
@@ -5996,38 +5996,16 @@ struct RGB2Luv_b
59965996
#elif CV_SSE2
59975997
if (haveSIMD)
59985998
{
5999-
for ( ; j <= (dn - 32) * 3; j += 96)
5999+
for ( ; j <= (dn - 16) * 3; j += 48)
60006000
{
6001-
__m128i v_l_0, v_u_0, v_v_0;
60026001
process(buf + j,
6003-
v_l_0, v_u_0, v_v_0);
6004-
6005-
__m128i v_l_1, v_u_1, v_v_1;
6006-
process(buf + j + 24,
6007-
v_l_1, v_u_1, v_v_1);
6008-
6009-
__m128i v_l0 = _mm_packus_epi16(v_l_0, v_l_1);
6010-
__m128i v_u0 = _mm_packus_epi16(v_u_0, v_u_1);
6011-
__m128i v_v0 = _mm_packus_epi16(v_v_0, v_v_1);
6012-
6013-
process(buf + j + 48,
6014-
v_l_0, v_u_0, v_v_0);
6015-
6016-
process(buf + j + 72,
6017-
v_l_1, v_u_1, v_v_1);
6018-
6019-
__m128i v_l1 = _mm_packus_epi16(v_l_0, v_l_1);
6020-
__m128i v_u1 = _mm_packus_epi16(v_u_0, v_u_1);
6021-
__m128i v_v1 = _mm_packus_epi16(v_v_0, v_v_1);
6002+
v_coeffs, v_res, dst + j);
60226003

6023-
_mm_interleave_epi8(v_l0, v_l1, v_u0, v_u1, v_v0, v_v1);
6004+
process(buf + j + 16,
6005+
v_coeffs, v_res, dst + j + 16);
60246006

6025-
_mm_storeu_si128((__m128i *)(dst + j), v_l0);
6026-
_mm_storeu_si128((__m128i *)(dst + j + 16), v_l1);
6027-
_mm_storeu_si128((__m128i *)(dst + j + 32), v_u0);
6028-
_mm_storeu_si128((__m128i *)(dst + j + 48), v_u1);
6029-
_mm_storeu_si128((__m128i *)(dst + j + 64), v_v0);
6030-
_mm_storeu_si128((__m128i *)(dst + j + 80), v_v1);
6007+
process(buf + j + 32,
6008+
v_coeffs, v_res, dst + j + 32);
60316009
}
60326010
}
60336011
#endif
@@ -6048,7 +6026,7 @@ struct RGB2Luv_b
60486026
float32x4_t v_scale, v_scale_inv, v_coeff1, v_coeff2, v_coeff3, v_coeff4;
60496027
uint8x8_t v_alpha;
60506028
#elif CV_SSE2
6051-
__m128 v_scale, v_scale_inv, v_coeff1, v_coeff2, v_coeff3, v_coeff4;
6029+
__m128 v_scale_inv;
60526030
__m128i v_zero;
60536031
bool haveSIMD;
60546032
#endif

0 commit comments

Comments
 (0)