Minor clean up

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/filter/ResponseFilter.java

@@ -15,7 +15,7 @@
 /**
  * A Filter interface that gets invoked before making the processing of the response bytes. {@link ResponseFilter} are invoked
  * before the actual response's status code get processed. That means authorization, proxy authentication and redirects
- * processing hasn't occured when {@link ResponseFilter} gets invoked.
+ * processing hasn't occurred when {@link ResponseFilter} gets invoked.
  */
 public interface ResponseFilter {
 

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/NettyAsyncHttpProvider.java

@@ -46,11 +46,9 @@ public class NettyAsyncHttpProvider implements AsyncHttpProvider {
     public NettyAsyncHttpProvider(AsyncHttpClientConfig config) {
 
         this.config = config;
-        if (config.getAsyncHttpProviderConfig() instanceof NettyAsyncHttpProviderConfig) {
-            asyncHttpProviderConfig = NettyAsyncHttpProviderConfig.class.cast(config.getAsyncHttpProviderConfig());
-        } else {
-            asyncHttpProviderConfig = new NettyAsyncHttpProviderConfig();
-        }
+        asyncHttpProviderConfig = config.getAsyncHttpProviderConfig() instanceof NettyAsyncHttpProviderConfig ? //
+        NettyAsyncHttpProviderConfig.class.cast(config.getAsyncHttpProviderConfig())
+                : new NettyAsyncHttpProviderConfig();
 
         channels = new Channels(config, asyncHttpProviderConfig);
         requestSender = new NettyRequestSender(closed, config, channels);

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/NettyChannelHandler.java

@@ -466,19 +466,17 @@ private void markAsDone(final NettyResponseFuture<?> future, final ChannelHandle
             }
         }
 
-        private boolean applyResponseFiltersAndReplayRequest(ChannelHandlerContext ctx, NettyResponseFuture future, HttpResponseStatus status, HttpResponseHeaders responseHeaders)
+        private boolean applyResponseFiltersAndReplayRequest(ChannelHandlerContext ctx, NettyResponseFuture<?> future, HttpResponseStatus status, HttpResponseHeaders responseHeaders)
                 throws IOException {
 
-            boolean replayed = false;
-
             AsyncHandler handler = future.getAsyncHandler();
             FilterContext fc = new FilterContext.FilterContextBuilder().asyncHandler(handler).request(future.getRequest()).responseStatus(status).responseHeaders(responseHeaders)
                     .build();
 
             for (ResponseFilter asyncFilter : config.getResponseFilters()) {
                 try {
                     fc = asyncFilter.filter(fc);
-                    // FIXME Is it work protecting against this?
+                    // FIXME Is it worth protecting against this?
                     if (fc == null) {
                         throw new NullPointerException("FilterContext is null");
                     }
@@ -494,9 +492,9 @@ private boolean applyResponseFiltersAndReplayRequest(ChannelHandlerContext ctx,
             // The request has changed
             if (fc.replayRequest()) {
                 requestSender.replayRequest(future, fc, ctx);
-                replayed = true;
+                return true;
             }
-            return replayed;
+            return false;
         }
 
         private boolean handleResponseAndExit(final ChannelHandlerContext ctx, final NettyResponseFuture<?> future, AsyncHandler<?> handler, HttpRequest nettyRequest,

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/future/NettyResponseFuture.java

@@ -258,7 +258,7 @@ public V getContent() throws ExecutionException {
         currentRetry.set(maxRetry);
         if (exEx.get() == null && !contentProcessed.getAndSet(true)) {
             try {
-                update = (V) asyncHandler.onCompleted();
+                update = asyncHandler.onCompleted();
             } catch (Throwable ex) {
                 if (!throwableCalled.getAndSet(true)) {
                     try {