Skip to content

Commit 173081e

Browse files
committed
- Removed SSL handshake logic from Grizzly's FeedableBodyGenerator. It's not needed anymore since the handshake is forced when the connection is made.
1 parent 8c1779a commit 173081e

File tree

1 file changed

+1
-36
lines changed

1 file changed

+1
-36
lines changed

providers/grizzly/src/main/java/org/asynchttpclient/providers/grizzly/FeedableBodyGenerator.java

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,16 @@
2323
import org.glassfish.grizzly.Connection;
2424
import org.glassfish.grizzly.WriteHandler;
2525
import org.glassfish.grizzly.WriteResult;
26-
import org.glassfish.grizzly.filterchain.FilterChain;
2726
import org.glassfish.grizzly.filterchain.FilterChainContext;
2827
import org.glassfish.grizzly.http.HttpContent;
2928
import org.glassfish.grizzly.http.HttpRequestPacket;
3029
import org.glassfish.grizzly.impl.FutureImpl;
3130
import org.glassfish.grizzly.nio.NIOConnection;
3231
import org.glassfish.grizzly.nio.SelectorRunner;
33-
import org.glassfish.grizzly.ssl.SSLBaseFilter;
34-
import org.glassfish.grizzly.ssl.SSLFilter;
3532
import org.glassfish.grizzly.utils.Futures;
3633

3734
import static java.lang.Boolean.TRUE;
3835
import static java.util.concurrent.TimeUnit.MILLISECONDS;
39-
import static org.glassfish.grizzly.ssl.SSLUtils.getSSLEngine;
4036
import static org.glassfish.grizzly.utils.Exceptions.*;
4137

4238
/**
@@ -176,12 +172,7 @@ public synchronized void initializeAsynchronousTransfer(final FilterChainContext
176172
@Override
177173
public void run() {
178174
try {
179-
if (requestPacket.isSecure() &&
180-
(getSSLEngine(context.getConnection()) == null)) {
181-
flushOnSSLHandshakeComplete();
182-
} else {
183-
feeder.flush();
184-
}
175+
feeder.flush();
185176
} catch (IOException ioe) {
186177
HttpTransactionContext ctx = HttpTransactionContext.get(c);
187178
ctx.abort(ioe);
@@ -210,32 +201,6 @@ private boolean isCurrentThreadSelectorRunner() {
210201
}
211202

212203

213-
private void flushOnSSLHandshakeComplete() throws IOException {
214-
final FilterChain filterChain = context.getFilterChain();
215-
final int idx = filterChain.indexOfType(SSLFilter.class);
216-
assert (idx != -1);
217-
final SSLFilter filter = (SSLFilter) filterChain.get(idx);
218-
final Connection c = context.getConnection();
219-
filter.addHandshakeListener(new SSLBaseFilter.HandshakeListener() {
220-
public void onStart(Connection connection) {
221-
}
222-
223-
public void onComplete(Connection connection) {
224-
if (c.equals(connection)) {
225-
filter.removeHandshakeListener(this);
226-
try {
227-
feeder.flush();
228-
} catch (IOException ioe) {
229-
HttpTransactionContext ctx = HttpTransactionContext.get(c);
230-
ctx.abort(ioe);
231-
}
232-
}
233-
}
234-
});
235-
filter.handshake(context.getConnection(), null);
236-
}
237-
238-
239204
// ----------------------------------------------------------- Inner Classes
240205

241206

0 commit comments

Comments
 (0)