Some comments

Author: Stephane Landelle

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/NettyChannelHandler.java

@@ -312,7 +312,8 @@ public void call() throws Exception {
 
                     Request target = nBuilder.setUrl(newUrl).build();
                     future.setRequest(target);
-                    requestSender.sendRequest(target, future);
+                    // FIXME why not reuse the channel is same host?
+                    requestSender.sendNextRequest(target, future);
                     return true;
                 }
             } else {
@@ -466,8 +467,8 @@ private void markAsDone(final NettyResponseFuture<?> future, final ChannelHandle
             }
         }
 
-        private boolean applyResponseFiltersAndReplayRequest(ChannelHandlerContext ctx, NettyResponseFuture<?> future, HttpResponseStatus status, HttpResponseHeaders responseHeaders)
-                throws IOException {
+        private boolean applyResponseFiltersAndReplayRequest(ChannelHandlerContext ctx, NettyResponseFuture<?> future, HttpResponseStatus status,
+                HttpResponseHeaders responseHeaders) throws IOException {
 
             AsyncHandler handler = future.getAsyncHandler();
             FilterContext fc = new FilterContext.FilterContextBuilder().asyncHandler(handler).request(future.getRequest()).responseStatus(status).responseHeaders(responseHeaders)
@@ -544,7 +545,7 @@ private boolean handleResponseAndExit(final ChannelHandlerContext ctx, final Net
                     Callback callback = new Callback(future) {
                         public void call() throws Exception {
                             channels.drainChannel(ctx, future);
-                            requestSender.sendRequest(builder.setHeaders(headers).setRealm(nr).build(), future);
+                            requestSender.sendNextRequest(builder.setHeaders(headers).setRealm(nr).build(), future);
                         }
                     };
 
@@ -562,7 +563,7 @@ public void call() throws Exception {
             } else if (statusCode == CONTINUE.code()) {
                 future.getAndSetWriteHeaders(false);
                 future.getAndSetWriteBody(true);
-                // FIXME is this necessary
+                // FIXME why not reuse the channel?
                 requestSender.writeRequest(ctx.channel(), config, future);
                 return true;
 
@@ -589,7 +590,7 @@ public void call() throws Exception {
 
                     future.setReuseChannel(true);
                     future.setConnectAllowed(true);
-                    requestSender.sendRequest(builder.setHeaders(headers).setRealm(newRealm).build(), future);
+                    requestSender.sendNextRequest(builder.setHeaders(headers).setRealm(newRealm).build(), future);
                     return true;
                 }
 
@@ -609,7 +610,7 @@ public void call() throws Exception {
                 }
                 future.setReuseChannel(true);
                 future.setConnectAllowed(false);
-                requestSender.sendRequest(builder.build(), future);
+                requestSender.sendNextRequest(builder.build(), future);
                 return true;
 
             }

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/NettyRequestSender.java

@@ -88,7 +88,7 @@ public boolean retry(Channel channel, NettyResponseFuture<?> future) {
                 LOGGER.debug("Trying to recover request {}\n", future.getNettyRequest());
 
                 try {
-                    sendRequest(future.getRequest(), future);
+                    sendNextRequest(future.getRequest(), future);
                     success = true;
 
                 } catch (IOException iox) {
@@ -103,9 +103,8 @@ public boolean retry(Channel channel, NettyResponseFuture<?> future) {
         return success;
     }
 
-    // FIXME Netty 3: only called from nextRequest, useCache, asyncConnect and
-    // reclaimCache always passed as true
-    public <T> void sendRequest(final Request request, final NettyResponseFuture<T> f) throws IOException {
+    public <T> void sendNextRequest(final Request request, final NettyResponseFuture<T> f) throws IOException {
+        // FIXME Why is sendNextRequest always asyncConnect?
         sendRequest(request, f.getAsyncHandler(), f, true, true);
     }
 
@@ -494,6 +493,6 @@ public void replayRequest(final NettyResponseFuture<?> future, FilterContext fc,
 
         LOGGER.debug("\n\nReplaying Request {}\n for Future {}\n", newRequest, future);
         channels.drainChannel(ctx, future);
-        sendRequest(newRequest, future);
+        sendNextRequest(newRequest, future);
     }
 }