Skip to content

Commit 11b9173

Browse files
author
Stephane Landelle
committed
minor clean up
1 parent 557c765 commit 11b9173

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

src/main/java/com/ning/http/client/websocket/WebSocketUpgradeHandler.java

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class WebSocketUpgradeHandler implements UpgradeHandler<WebSocket>, Async
3030
private WebSocket webSocket;
3131
private final List<WebSocketListener> listeners;
3232
private final AtomicBoolean ok = new AtomicBoolean(false);
33-
private final AtomicBoolean onSuccessCalled = new AtomicBoolean(false);
33+
private boolean onSuccessCalled;
3434
private int status;
3535

3636
protected WebSocketUpgradeHandler(List<WebSocketListener> listeners) {
@@ -43,11 +43,9 @@ public void onThrowable(Throwable t) {
4343
}
4444

4545
public boolean touchSuccess() {
46-
return onSuccessCalled.getAndSet(true);
47-
}
48-
49-
public void resetSuccess() {
50-
onSuccessCalled.set(false);
46+
boolean prev = onSuccessCalled;
47+
onSuccessCalled = true;
48+
return prev;
5149
}
5250

5351
@Override
@@ -58,11 +56,7 @@ public STATE onBodyPartReceived(HttpResponseBodyPart bodyPart) throws Exception
5856
@Override
5957
public STATE onStatusReceived(HttpResponseStatus responseStatus) throws Exception {
6058
status = responseStatus.getStatusCode();
61-
if (responseStatus.getStatusCode() == 101) {
62-
return STATE.UPGRADE;
63-
} else {
64-
return STATE.ABORT;
65-
}
59+
return status == 101 ? STATE.UPGRADE : STATE.ABORT;
6660
}
6761

6862
@Override

0 commit comments

Comments
 (0)