Clean up TimeoutTasks content when cancelling, close AsyncHttpClient#682

Author: Stephane Landelle

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/timeout/TimeoutTimerTask.java

@@ -26,7 +26,7 @@ public abstract class TimeoutTimerTask implements TimerTask {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(TimeoutTimerTask.class);
 
-    protected final NettyResponseFuture<?> nettyResponseFuture;
+    protected volatile NettyResponseFuture<?> nettyResponseFuture;
     protected final NettyRequestSender requestSender;
     protected final TimeoutsHolder timeoutsHolder;
 
@@ -43,4 +43,12 @@ protected void expire(String message, long ms) {
         LOGGER.debug("{} for {} after {} ms", message, nettyResponseFuture, ms);
         requestSender.abort(nettyResponseFuture, new TimeoutException(message));
     }
+
+    /**
+     * When the timeout is cancelled, it could still be referenced for quite some time in the Timer.
+     * Holding a reference to the future might mean holding a reference to the channel, and heavy objects such as SslEngines
+     */
+    public void clean() {
+        nettyResponseFuture = null;
+    }
 }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/timeout/TimeoutsHolder.java

@@ -27,10 +27,12 @@ public void cancel() {
         if (cancelled.compareAndSet(false, true)) {
             if (requestTimeout != null) {
                 requestTimeout.cancel();
+                RequestTimeoutTimerTask.class.cast(requestTimeout.task()).clean();
                 requestTimeout = null;
             }
             if (readTimeout != null) {
                 readTimeout.cancel();
+                ReadTimeoutTimerTask.class.cast(readTimeout.task()).clean();
                 readTimeout = null;
             }
         }