Fix NPE caused by AsyncHttpClient#676, close AsyncHttpClient#678

Author: Stephane Landelle

src/main/java/com/ning/http/client/providers/netty/channel/pool/DefaultChannelPool.java

@@ -29,7 +29,6 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
-import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.TimeUnit;
@@ -195,21 +194,21 @@ public void run(Timeout timeout) throws Exception {
                 int closedCount = 0;
                 int totalCount = 0;
 
-                for (Map.Entry<String, ConcurrentLinkedQueue<IdleChannel>> entry : poolsPerKey.entrySet()) {
-
-                    String poolKey = entry.getKey();
-                    ConcurrentLinkedQueue<IdleChannel> pool = entry.getValue();
+                for (ConcurrentLinkedQueue<IdleChannel> pool : poolsPerKey.values()) {
 
                     // store in intermediate unsynchronized lists to minimize the impact on the ConcurrentLinkedQueue
                     if (LOGGER.isDebugEnabled())
                         totalCount += pool.size();
 
                     List<IdleChannel> closedChannels = closeChannels(expiredChannels(pool, start));
 
-                    pool.removeAll(closedChannels);
-                    closedCount += closedChannels.size();
-                    if (pool.isEmpty())
-                        poolsPerKey.remove(poolKey);
+                    if (!closedChannels.isEmpty()) {
+                        for (IdleChannel closedChannel : closedChannels)
+                            channelId2Creation.remove(closedChannel.channel.getId());
+
+                        pool.removeAll(closedChannels);
+                        closedCount += closedChannels.size();
+                    }
                 }
 
                 long duration = millisTime() - start;