feat: fix all lint errors

Author: trungvose

frontend/.eslintrc.json

@@ -57,7 +57,9 @@
         ],
         "typescript-eslint/quotes": "off",
         "no-underscore-dangle": "off",
-        "radix": "off"
+        "radix": "off",
+        "max-len": "off",
+        "prefer-arrow/prefer-arrow-functions": "off"
       }
     },
     {

frontend/src/app/app.component.ts

@@ -30,7 +30,7 @@ export class AppComponent implements AfterViewInit {
     if (event instanceof NavigationEnd) {
       this._googleAnalytics.sendPageView(event.urlAfterRedirects);
     }
-  }
+  };
 
   ngAfterViewInit() {
     this._cdr.detectChanges();

frontend/src/app/core/services/google-analytics.service.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-declare var gtag: any;
+declare const gtag: any;
 const GOOGLE_ANALYTICS_ID = 'UA-80363801-4';
 @Injectable({
   providedIn: 'root'
@@ -22,16 +22,19 @@ export class GoogleAnalyticsService {
       return;
     }
     this.gtag('event', eventName, {
+      /* eslint-disable @typescript-eslint/naming-convention */
       event_category: eventCategory,
       event_label: eventLabel,
+      /* eslint-enable @typescript-eslint/naming-convention */
       value: eventValue
     });
-  }
+  };
 
   public sendPageView(url: string) {
     if (!this.gtag) {
       return;
     }
+    // eslint-disable-next-line @typescript-eslint/naming-convention
     this.gtag('config', GOOGLE_ANALYTICS_ID, { page_path: url });
   }
 }

frontend/src/app/core/validators/no-whitespace.validator.ts

@@ -1,5 +1,6 @@
 import { AbstractControl, ValidatorFn } from '@angular/forms';
 
+// eslint-disable-next-line @typescript-eslint/naming-convention
 export function NoWhitespaceValidator(): ValidatorFn {
   return (control: AbstractControl): { [key: string]: any } => {
     let controlVal = control.value;

frontend/src/app/interface/comment.ts

@@ -1,15 +1,6 @@
 import { JUser } from './user';
 
 export class JComment {
-  constructor(issueId: string, user: JUser) {
-    const now = new Date();
-    this.id = `${now.getTime()}`;
-    this.issueId = issueId;
-    this.user = user;
-    this.createdAt = now.toISOString();
-    this.updatedAt = now.toISOString();
-  }
-
   id: string;
   body: string;
   createdAt: string;
@@ -18,4 +9,13 @@ export class JComment {
   userId: string;
   // mapped to display by userId
   user: JUser;
+
+  constructor(issueId: string, user: JUser) {
+    const now = new Date();
+    this.id = `${now.getTime()}`;
+    this.issueId = issueId;
+    this.user = user;
+    this.createdAt = now.toISOString();
+    this.updatedAt = now.toISOString();
+  }
 }

frontend/src/app/interface/issue.ts

@@ -1,5 +1,7 @@
+
 import { JComment } from './comment';
 
+/* eslint-disable no-shadow */
 export enum IssueType {
   STORY = 'Story',
   TASK = 'Task',
@@ -9,6 +11,7 @@ export enum IssueType {
 export enum IssueStatus {
   BACKLOG = 'Backlog',
   SELECTED = 'Selected',
+  // eslint-disable-next-line @typescript-eslint/naming-convention
   IN_PROGRESS = 'InProgress',
   DONE = 'Done'
 }
@@ -53,3 +56,4 @@ export interface JIssue {
   comments: JComment[];
   projectId: string;
 }
+/* eslint-enable no-shadow */

frontend/src/app/interface/project.ts

@@ -13,6 +13,7 @@ export interface JProject {
   users: JUser[];
 }
 
+// eslint-disable-next-line no-shadow
 export enum ProjectCategory {
   SOFTWARE = 'Software',
   MARKETING = 'Marketing',

frontend/src/app/jira-control/avatar/avatar.stories.ts

@@ -16,13 +16,13 @@ const Template: Story<AvatarComponent> = (args: AvatarComponent) => ({
 
 export const Rounded: Story<AvatarComponent> = Template.bind({});
 Rounded.args = {
-  avatarUrl: avatarUrl,
+  avatarUrl,
   size: 64
 };
 
 export const Square: Story<AvatarComponent> = Template.bind({});
 Square.args = {
-  avatarUrl: avatarUrl,
+  avatarUrl,
   size: 64,
   rounded: false
 };

frontend/src/app/jira-control/button/button.stories.ts

@@ -33,7 +33,7 @@ Secondary.args = {
 
 export const Empty: Story<ButtonProps> = Template.bind({});
 Empty.args = {
-  icon: "times",
+  icon: 'times',
   className: 'btn-empty',
   label: 'Cancel'
 };

frontend/src/app/project/auth/auth.query.ts

@@ -4,10 +4,10 @@ import { Query } from '@datorama/akita';
 
 @Injectable({ providedIn: 'root' })
 export class AuthQuery extends Query<AuthState> {
+  user$ = this.select();
+  userId$ = this.select('id');
+
   constructor(protected store: AuthStore) {
     super(store);
   }
-
-  user$ = this.select();
-  userId$ = this.select('id');
 }