Skip to content

Commit 689e2e4

Browse files
authored
Merge pull request krausest#381 from evs-chris/win
close before quit to avoid zombie instances on windows
2 parents b43eee1 + fbd12cc commit 689e2e4

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

webdriver-ts/src/benchmarkRunner.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,10 +377,12 @@ async function runMemOrCPUBenchmark(framework: FrameworkData, benchmark: Benchma
377377
let results = benchmark.type === BenchmarkType.CPU ? await computeResultsCPU(driver) : await computeResultsMEM(driver);
378378
await writeResult({framework: framework, results: results, benchmark: benchmark}, dir);
379379
console.log("QUIT");
380+
await driver.close();
380381
await driver.quit();
381382
} catch (e) {
382383
console.log("ERROR:", e);
383384
console.log("QUIT");
385+
await driver.close();
384386
await driver.quit();
385387
if (config.EXIT_ON_ERROR) { throw "Benchmarking failed"}
386388
}
@@ -408,6 +410,7 @@ async function runStartupBenchmark(framework: FrameworkData, benchmark: Benchmar
408410
await registerError(driver, framework, benchmark, e);
409411
throw e;
410412
} finally {
413+
await driver.close();
411414
await driver.quit();
412415
}
413416
}

0 commit comments

Comments
 (0)