Skip to content

Commit e44d419

Browse files
committed
Add Log for When Typings Installer Finishes Updating the Types Registry
**Bug** While investigating microsoft#15301, I was confused by the typing installer's log `Updating types-registry npm package...`. This was often the last line of the log file, leading me to believe that the types-registry update was still ongoing **Fix** Add an extra log for when the type-registry update completes successfully
1 parent 96aca4c commit e44d419

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/server/typingsInstaller/nodeTypingsInstaller.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,9 @@ namespace ts.server.typingsInstaller {
9696
this.log.writeLine(`Updating ${TypesRegistryPackageName} npm package...`);
9797
}
9898
this.execSync(`${this.npmPath} install ${TypesRegistryPackageName}`, { cwd: globalTypingsCacheLocation, stdio: "ignore" });
99+
if (this.log.isEnabled()) {
100+
this.log.writeLine(`Updated ${TypesRegistryPackageName} npm package`);
101+
}
99102
}
100103
catch (e) {
101104
if (this.log.isEnabled()) {

0 commit comments

Comments
 (0)