Skip to content

Commit b0d27ee

Browse files
committed
chore(build): add IE10 to CI
1 parent 9ba2ab5 commit b0d27ee

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

modules/angular2/src/dom/browser_adapter.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,10 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
299299
}
300300
resetBaseElement(): void { baseElement = null; }
301301
getUserAgent(): string { return window.navigator.userAgent; }
302-
setData(element, name: string, value: string) { element.dataset[name] = value; }
303-
getData(element, name: string): string { return element.dataset[name]; }
302+
setData(element, name: string, value: string) {
303+
this.setAttribute(element, 'data-' + name, value);
304+
}
305+
getData(element, name: string): string { return this.getAttribute(element, 'data-' + name); }
304306
// TODO(tbosch): move this into a separate environment class once we have it
305307
setGlobalVar(name: string, value: any) { global[name] = value; }
306308
}

modules/angular2/test/core/compiler/integration_spec.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,7 +1060,7 @@ export function main() {
10601060
var tc = rootTC.componentViewChildren[0];
10611061
var needsAttribute = tc.inject(NeedsAttribute);
10621062
expect(needsAttribute.typeAttribute).toEqual('text');
1063-
expect(needsAttribute.titleAttribute).toEqual('');
1063+
expect(needsAttribute.staticAttribute).toEqual('');
10641064
expect(needsAttribute.fooAttribute).toEqual(null);
10651065

10661066
async.done();
@@ -1886,12 +1886,13 @@ class IdDir {
18861886
@Injectable()
18871887
class NeedsAttribute {
18881888
typeAttribute;
1889-
titleAttribute;
1889+
staticAttribute;
18901890
fooAttribute;
1891-
constructor(@Attribute('type') typeAttribute: String, @Attribute('title') titleAttribute: String,
1891+
constructor(@Attribute('type') typeAttribute: String,
1892+
@Attribute('static') staticAttribute: String,
18921893
@Attribute('foo') fooAttribute: String) {
18931894
this.typeAttribute = typeAttribute;
1894-
this.titleAttribute = titleAttribute;
1895+
this.staticAttribute = staticAttribute;
18951896
this.fooAttribute = fooAttribute;
18961897
}
18971898
}

sauce.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ var aliases = {
125125
'SAFARI': ['SL_SAFARI7', 'SL_SAFARI8'],
126126
'BETA': ['SL_CHROMEBETA', 'SL_FIREFOXBETA'],
127127
'DEV': ['SL_CHROMEDEV', 'SL_FIREFOXDEV'],
128-
'CI': ['SL_CHROME', 'SL_ANDROID5.1', 'SL_SAFARI8', 'SL_IOS8', 'SL_FIREFOX', 'SL_IE11']
128+
'CI': ['SL_CHROME', 'SL_ANDROID5.1', 'SL_SAFARI8', 'SL_IOS8', 'SL_FIREFOX', 'SL_IE11', 'SL_IE10']
129129
};
130130

131131
module.exports = {

0 commit comments

Comments
 (0)