AsyncHttpClient#1686 configure accuracy in HashedTimerWheel (AsyncHttpClient#1705)

Author: zagorulkinde

client/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java

@@ -306,6 +306,16 @@ public interface AsyncHttpClientConfig {
 
   Timer getNettyTimer();
 
+  /**
+   * @return the duration between tick of {@link io.netty.util.HashedWheelTimer}
+   */
+  long getHashedWheelTimerTickDuration();
+
+  /**
+   * @return the size of the hashed wheel {@link io.netty.util.HashedWheelTimer}
+   */
+  int getHashedWheelTimerSize();
+
   KeepAliveStrategy getKeepAliveStrategy();
 
   boolean isValidateResponseHeaders();

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClient.java

@@ -33,6 +33,7 @@
 
 import java.util.List;
 import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Predicate;
 
@@ -93,8 +94,7 @@ public DefaultAsyncHttpClient(AsyncHttpClientConfig config) {
 
   private Timer newNettyTimer(AsyncHttpClientConfig config) {
     ThreadFactory threadFactory = config.getThreadFactory() != null ? config.getThreadFactory() : new DefaultThreadFactory(config.getThreadPoolName() + "-timer");
-
-    HashedWheelTimer timer = new HashedWheelTimer(threadFactory);
+    HashedWheelTimer timer = new HashedWheelTimer(threadFactory, config.getHashedWheelTimerTickDuration(), TimeUnit.MILLISECONDS, config.getHashedWheelTimerSize());
     timer.start();
     return timer;
   }

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java

@@ -133,6 +133,8 @@ public class DefaultAsyncHttpClientConfig implements AsyncHttpClientConfig {
   private final Consumer<Channel> wsAdditionalChannelInitializer;
   private final ResponseBodyPartFactory responseBodyPartFactory;
   private final int ioThreadsCount;
+  private final long hashedWheelTimerTickDuration;
+  private final int hashedWheelTimerSize;
 
   private DefaultAsyncHttpClientConfig(// http
                                        boolean followRedirect,
@@ -217,7 +219,9 @@ private DefaultAsyncHttpClientConfig(// http
                                        Consumer<Channel> httpAdditionalChannelInitializer,
                                        Consumer<Channel> wsAdditionalChannelInitializer,
                                        ResponseBodyPartFactory responseBodyPartFactory,
-                                       int ioThreadsCount) {
+                                       int ioThreadsCount,
+                                       long hashedWheelTimerTickDuration,
+                                       int hashedWheelTimerSize) {
 
     // http
     this.followRedirect = followRedirect;
@@ -305,6 +309,8 @@ private DefaultAsyncHttpClientConfig(// http
     this.wsAdditionalChannelInitializer = wsAdditionalChannelInitializer;
     this.responseBodyPartFactory = responseBodyPartFactory;
     this.ioThreadsCount = ioThreadsCount;
+    this.hashedWheelTimerTickDuration = hashedWheelTimerTickDuration;
+    this.hashedWheelTimerSize = hashedWheelTimerSize;
   }
 
   @Override
@@ -639,6 +645,16 @@ public Timer getNettyTimer() {
     return nettyTimer;
   }
 
+  @Override
+  public long getHashedWheelTimerTickDuration() {
+    return hashedWheelTimerTickDuration;
+  }
+
+  @Override
+  public int getHashedWheelTimerSize() {
+    return hashedWheelTimerSize;
+  }
+
   @Override
   public ThreadFactory getThreadFactory() {
     return threadFactory;
@@ -756,6 +772,8 @@ public static class Builder {
     private Consumer<Channel> wsAdditionalChannelInitializer;
     private ResponseBodyPartFactory responseBodyPartFactory = ResponseBodyPartFactory.EAGER;
     private int ioThreadsCount = defaultIoThreadsCount();
+    private long hashedWheelTickDuration = defaultHashedWheelTimerTickDuration();
+    private int hashedWheelSize = defaultHashedWheelTimerSize();
 
     public Builder() {
     }
@@ -838,6 +856,8 @@ public Builder(AsyncHttpClientConfig config) {
       wsAdditionalChannelInitializer = config.getWsAdditionalChannelInitializer();
       responseBodyPartFactory = config.getResponseBodyPartFactory();
       ioThreadsCount = config.getIoThreadsCount();
+      hashedWheelTickDuration = config.getHashedWheelTimerTickDuration();
+      hashedWheelSize = config.getHashedWheelTimerSize();
     }
 
     // http
@@ -1188,6 +1208,16 @@ public Builder setChunkedFileChunkSize(int chunkedFileChunkSize) {
       return this;
     }
 
+    public Builder setHashedWheelTickDuration(long hashedWheelTickDuration) {
+      this.hashedWheelTickDuration = hashedWheelTickDuration;
+      return this;
+    }
+
+    public Builder setHashedWheelSize(int hashedWheelSize) {
+      this.hashedWheelSize = hashedWheelSize;
+      return this;
+    }
+
     @SuppressWarnings("unchecked")
     public <T> Builder addChannelOption(ChannelOption<T> name, T value) {
       channelOptions.put((ChannelOption<Object>) name, value);
@@ -1323,7 +1353,9 @@ public DefaultAsyncHttpClientConfig build() {
               httpAdditionalChannelInitializer,
               wsAdditionalChannelInitializer,
               responseBodyPartFactory,
-              ioThreadsCount);
+              ioThreadsCount,
+              hashedWheelTickDuration,
+              hashedWheelSize);
     }
   }
 }

client/src/main/java/org/asynchttpclient/config/AsyncHttpClientConfigDefaults.java

@@ -71,6 +71,8 @@ public final class AsyncHttpClientConfigDefaults {
   public static final String SHUTDOWN_TIMEOUT_CONFIG = "shutdownTimeout";
   public static final String USE_NATIVE_TRANSPORT_CONFIG = "useNativeTransport";
   public static final String IO_THREADS_COUNT_CONFIG = "ioThreadsCount";
+  public static final String HASHED_WHEEL_TIMER_TICK_DURATION = "hashedWheelTimerTickDuration";
+  public static final String HASHED_WHEEL_TIMER_SIZE = "hashedWheelTimerSize";
 
   public static final String AHC_VERSION;
 
@@ -294,4 +296,12 @@ public static boolean defaultUseNativeTransport() {
   public static int defaultIoThreadsCount() {
     return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getInt(ASYNC_CLIENT_CONFIG_ROOT + IO_THREADS_COUNT_CONFIG);
   }
+
+  public static int defaultHashedWheelTimerTickDuration() {
+    return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getInt(ASYNC_CLIENT_CONFIG_ROOT + HASHED_WHEEL_TIMER_TICK_DURATION);
+  }
+
+  public static int defaultHashedWheelTimerSize() {
+    return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getInt(ASYNC_CLIENT_CONFIG_ROOT + HASHED_WHEEL_TIMER_SIZE);
+  }
 }

client/src/main/resources/org/asynchttpclient/config/ahc-default.properties

@@ -50,3 +50,5 @@ org.asynchttpclient.shutdownQuietPeriod=2000
 org.asynchttpclient.shutdownTimeout=15000
 org.asynchttpclient.useNativeTransport=false
 org.asynchttpclient.ioThreadsCount=0
+org.asynchttpclient.hashedWheelTimerTickDuration=100
+org.asynchttpclient.hashedWheelTimerSize=512

client/src/test/java/org/asynchttpclient/AsyncHttpClientDefaultsTest.java

@@ -115,6 +115,16 @@ public void testDefaultUseInsecureTrustManager() {
     testBooleanSystemProperty("useInsecureTrustManager", "defaultUseInsecureTrustManager", "false");
   }
 
+  public void testDefaultHashedWheelTimerTickDuration() {
+    Assert.assertEquals(AsyncHttpClientConfigDefaults.defaultHashedWheelTimerTickDuration(), 100);
+    testIntegerSystemProperty("hashedWheelTimerTickDuration", "defaultHashedWheelTimerTickDuration", "100");
+  }
+
+  public void testDefaultHashedWheelTimerSize() {
+    Assert.assertEquals(AsyncHttpClientConfigDefaults.defaultHashedWheelTimerSize(), 512);
+    testIntegerSystemProperty("hashedWheelTimerSize", "defaultHashedWheelTimerSize", "512");
+  }
+
   private void testIntegerSystemProperty(String propertyName, String methodName, String value) {
     String previous = System.getProperty(ASYNC_CLIENT_CONFIG_ROOT + propertyName);
     System.setProperty(ASYNC_CLIENT_CONFIG_ROOT + propertyName, value);

client/src/test/java/org/asynchttpclient/spnego/SpnegoEngineTest.java

@@ -135,9 +135,7 @@ public void testGetCompleteServicePrincipalName() throws Exception {
           null,
           null,
           null);
-      // FIXME see https://github.com/AsyncHttpClient/async-http-client/issues/1706
-      // InetAddress.getByName("localhost").getCanonicalHostName() returns 127.0.0.1 with JDK8 and localhost with JDK11.
-      // Assert.assertNotEquals("HTTP@localhost", spnegoEngine.getCompleteServicePrincipalName("localhost"));
+      Assert.assertNotEquals("HTTP@localhost", spnegoEngine.getCompleteServicePrincipalName("localhost"));
       Assert.assertTrue(spnegoEngine.getCompleteServicePrincipalName("localhost").startsWith("HTTP@"));
     }
     {

extras/typesafeconfig/src/main/java/org/asynchttpclient/extras/typesafeconfig/AsyncHttpClientTypesafeConfig.java

@@ -339,6 +339,16 @@ public Timer getNettyTimer() {
     return null;
   }
 
+  @Override
+  public long getHashedWheelTimerTickDuration() {
+    return getIntegerOpt(HASHED_WHEEL_TIMER_TICK_DURATION).orElse(defaultHashedWheelTimerTickDuration());
+  }
+
+  @Override
+  public int getHashedWheelTimerSize() {
+    return getIntegerOpt(HASHED_WHEEL_TIMER_SIZE).orElse(defaultHashedWheelTimerSize());
+  }
+
   @Override
   public KeepAliveStrategy getKeepAliveStrategy() {
     return new DefaultKeepAliveStrategy();