Skip to content

Commit 2136f8f

Browse files
Clarify names during testing
1 parent 34a2561 commit 2136f8f

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

rxjava-core/src/main/java/rx/observers/SerializedObserver.java renamed to rxjava-core/src/main/java/rx/observers/SerializedObserverViaQueueAndCounter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import rx.Observer;
77

8-
public class SerializedObserver<T> implements Observer<T> {
8+
public class SerializedObserverViaQueueAndCounter<T> implements Observer<T> {
99
private final Observer<? super T> actual;
1010
private final AtomicInteger count = new AtomicInteger();
1111
private final ConcurrentLinkedQueue<Object> queue = new ConcurrentLinkedQueue<Object>();
@@ -25,7 +25,7 @@ private static class ErrorSentinel extends Sentinel {
2525
}
2626
}
2727

28-
public SerializedObserver(Observer<? super T> s) {
28+
public SerializedObserverViaQueueAndCounter(Observer<? super T> s) {
2929
this.actual = s;
3030
}
3131

rxjava-core/src/test/java/rx/observers/SerializedObserverTest.java renamed to rxjava-core/src/test/java/rx/observers/SerializedObserverViaQueueAndCounterTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import rx.Subscriber;
3838
import rx.Subscription;
3939

40-
public class SerializedObserverTest {
40+
public class SerializedObserverViaQueueAndCounterTest {
4141

4242
@Mock
4343
Subscriber<String> observer;
@@ -53,7 +53,7 @@ public void testSingleThreadedBasic() {
5353
TestSingleThreadedObservable onSubscribe = new TestSingleThreadedObservable(s, "one", "two", "three");
5454
Observable<String> w = Observable.create(onSubscribe);
5555

56-
SerializedObserver<String> aw = new SerializedObserver<String>(observer);
56+
SerializedObserverViaQueueAndCounter<String> aw = new SerializedObserverViaQueueAndCounter<String>(observer);
5757

5858
w.subscribe(aw);
5959
onSubscribe.waitToFinish();
@@ -75,7 +75,7 @@ public void testMultiThreadedBasic() {
7575
Observable<String> w = Observable.create(onSubscribe);
7676

7777
BusyObserver busyObserver = new BusyObserver();
78-
SerializedObserver<String> aw = new SerializedObserver<String>(busyObserver);
78+
SerializedObserverViaQueueAndCounter<String> aw = new SerializedObserverViaQueueAndCounter<String>(busyObserver);
7979

8080
w.subscribe(aw);
8181
onSubscribe.waitToFinish();
@@ -100,7 +100,7 @@ public void testMultiThreadedWithNPE() throws InterruptedException {
100100
Observable<String> w = Observable.create(onSubscribe);
101101

102102
BusyObserver busyObserver = new BusyObserver();
103-
SerializedObserver<String> aw = new SerializedObserver<String>(busyObserver);
103+
SerializedObserverViaQueueAndCounter<String> aw = new SerializedObserverViaQueueAndCounter<String>(busyObserver);
104104

105105
w.subscribe(aw);
106106
onSubscribe.waitToFinish();
@@ -132,7 +132,7 @@ public void testMultiThreadedWithNPEinMiddle() {
132132
Observable<String> w = Observable.create(onSubscribe);
133133

134134
BusyObserver busyObserver = new BusyObserver();
135-
SerializedObserver<String> aw = new SerializedObserver<String>(busyObserver);
135+
SerializedObserverViaQueueAndCounter<String> aw = new SerializedObserverViaQueueAndCounter<String>(busyObserver);
136136

137137
w.subscribe(aw);
138138
onSubscribe.waitToFinish();
@@ -168,7 +168,7 @@ public void runOutOfOrderConcurrencyTest() {
168168
try {
169169
TestConcurrencyObserver tw = new TestConcurrencyObserver();
170170
// we need Synchronized + SafeSubscriber to handle synchronization plus life-cycle
171-
SerializedObserver<String> w = new SerializedObserver<String>(new SafeSubscriber<String>(tw));
171+
SerializedObserverViaQueueAndCounter<String> w = new SerializedObserverViaQueueAndCounter<String>(new SafeSubscriber<String>(tw));
172172

173173
Future<?> f1 = tp.submit(new OnNextThread(w, 12000));
174174
Future<?> f2 = tp.submit(new OnNextThread(w, 5000));
@@ -223,7 +223,7 @@ public void runConcurrencyTest() {
223223
try {
224224
TestConcurrencyObserver tw = new TestConcurrencyObserver();
225225
// we need Synchronized + SafeSubscriber to handle synchronization plus life-cycle
226-
SerializedObserver<String> w = new SerializedObserver<String>(new SafeSubscriber<String>(tw));
226+
SerializedObserverViaQueueAndCounter<String> w = new SerializedObserverViaQueueAndCounter<String>(new SafeSubscriber<String>(tw));
227227

228228
Future<?> f1 = tp.submit(new OnNextThread(w, 12000));
229229
Future<?> f2 = tp.submit(new OnNextThread(w, 5000));
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package rx.observers;
22

3-
public class SerializedObserverViaStateMachineTest extends SerializedObserverTest {
3+
public class SerializedObserverViaStateMachineTest extends SerializedObserverViaQueueAndCounterTest {
44

55
}

0 commit comments

Comments
 (0)