Revert "ESP8266mDNS using the provided IP in the begin method (esp8266#2349)"

Manually specifying the AP IP isn't required; the next change will modify
the MDNS code to correctly handle any combination of AP and STA modes, and
correctly respond to requests on all active interfaces.

This reverts commit b682d59.

Author: swarren

libraries/ESP8266mDNS/ESP8266mDNS.cpp

@@ -146,39 +146,26 @@ MDNSResponder::~MDNSResponder() {
   }
 }
 
-bool MDNSResponder::begin(const char* hostName){
-  return _begin(hostName, 0, 120);
-}
-
-bool MDNSResponder::begin(const char* hostName, IPAddress ip, uint32_t ttl){
-  return _begin(hostName, ip, ttl);
-}
-
-bool MDNSResponder::_begin(const char *hostName, uint32_t ip, uint32_t ttl){
-  size_t n = strlen(hostName);
+bool MDNSResponder::begin(const char* hostname){
+  size_t n = strlen(hostname);
   if (n > 63) { // max size for a single label.
     return false;
   }
 
-  _ip = ip;
-
   // Copy in hostname characters as lowercase
-  _hostName = hostName;
+  _hostName = hostname;
   _hostName.toLowerCase();
 
   // If instance name is not already set copy hostname to instance name
-  if (_instanceName.equals("") ) _instanceName=hostName;
+  if (_instanceName.equals("") ) _instanceName=hostname;
 
-  //only if the IP hasn't been set manually, use the events
-  if (ip == 0) {
-    _gotIPHandler = WiFi.onStationModeGotIP([this](const WiFiEventStationModeGotIP& event){
-      _restart();
-    });
+  _gotIPHandler = WiFi.onStationModeGotIP([this](const WiFiEventStationModeGotIP& event){
+    _restart();
+  });
 
-    _disconnectedHandler = WiFi.onStationModeDisconnected([this](const WiFiEventStationModeDisconnected& event) {
-      _restart();
-    });
-  }
+  _disconnectedHandler = WiFi.onStationModeDisconnected([this](const WiFiEventStationModeDisconnected& event) {
+    _restart();
+  });
 
   return _listen();
 }
@@ -459,11 +446,7 @@ uint16_t MDNSResponder::_getServicePort(char *name, char *proto){
 
 uint32_t MDNSResponder::_getOurIp(){
   int mode = wifi_get_opmode();
-
-  //if has a manually set IP use this
-  if(_ip){
-    return _ip;
-  } else if(mode & STATION_MODE){
+  if(mode & STATION_MODE){
     struct ip_info staIpInfo;
     wifi_get_ip_info(STATION_IF, &staIpInfo);
     return staIpInfo.ip.addr;

libraries/ESP8266mDNS/ESP8266mDNS.h

@@ -63,7 +63,9 @@ class MDNSResponder {
   ~MDNSResponder();
   bool begin(const char* hostName);
   //for compatibility
-  bool begin(const char* hostName, IPAddress ip, uint32_t ttl=120);
+  bool begin(const char* hostName, IPAddress ip, uint32_t ttl=120){
+    return begin(hostName);
+  }
   void update();
 
   void addService(char *service, char *proto, uint16_t port);
@@ -114,9 +116,8 @@ class MDNSResponder {
   bool _waitingForAnswers;
   WiFiEventHandler _disconnectedHandler;
   WiFiEventHandler _gotIPHandler;
-  uint32_t _ip;
+  
 
-  bool _begin(const char* hostName, uint32_t ip, uint32_t ttl);
   uint32_t _getOurIp();
   uint16_t _getServicePort(char *service, char *proto);
   MDNSTxt * _getServiceTxt(char *name, char *proto);