From 29f58a6b7d7ac8c128abbc7a544b3ddada2c0583 Mon Sep 17 00:00:00 2001 From: genuinefafa Date: Wed, 10 Aug 2016 12:53:59 -0300 Subject: [PATCH 1/5] Update README.md minor fix, aknowledge by use --- src/directives/pagination/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/directives/pagination/README.md b/src/directives/pagination/README.md index 6791ebe..429d6a0 100644 --- a/src/directives/pagination/README.md +++ b/src/directives/pagination/README.md @@ -165,7 +165,7 @@ The optional third argument `paginationId` is used when you need more than one i on setting up multiple instances. * **`current-page`** (optional) Specify a property on your controller's $scope that will be bound to the current -page of the pagination. If this is not specified, the directive will automatically create a property named `__currentPage` and use +page of the pagination. If this is not specified, the directive will automatically create a property named `__default__currentPage` and use that instead. * **`pagination-id`** (optional) Used to group together the dir-paginate directive with a corresponding dir-pagination-controls when you need more than From eb92e9533dd92fac75286911f8328549c8bab856 Mon Sep 17 00:00:00 2001 From: imdark Date: Wed, 21 Sep 2016 23:30:43 -0400 Subject: [PATCH 2/5] Added an '_' to prevent syntax error in some cases Adding the '_' as a prefix resolves an issue where paginationId might be have a digit as its first char See https://github.com/michaelbromley/angularUtils/issues/400 --- src/directives/pagination/dirPagination.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/directives/pagination/dirPagination.js b/src/directives/pagination/dirPagination.js index a1a7265..d5103ff 100644 --- a/src/directives/pagination/dirPagination.js +++ b/src/directives/pagination/dirPagination.js @@ -201,7 +201,9 @@ // Replace any non-alphanumeric characters which might confuse // the $parse service and give unexpected results. // See https://github.com/michaelbromley/angularUtils/issues/233 - var defaultCurrentPage = (paginationId + '__currentPage').replace(/\W/g, '_'); + // Adding the '_' as a prefix resolves an issue where paginationId might be have a digit as its first char + // See https://github.com/michaelbromley/angularUtils/issues/400 + var defaultCurrentPage = '_' + (paginationId + '__currentPage').replace(/\W/g, '_'); scope[defaultCurrentPage] = 1; currentPageGetter = $parse(defaultCurrentPage); } From db8d31d09ad7ec95f91d5a170a263fd9f88a88e4 Mon Sep 17 00:00:00 2001 From: Michael Bromley Date: Thu, 20 Apr 2017 09:25:55 +0200 Subject: [PATCH 3/5] update readme --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index b8338d9..ac0d61e 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,10 @@ # Angular Utilities +### No longer maintained +(20/04/2017) - I am no longer actively maintaining this project. I no longer use AngularJS in my own projects and do not have the time to dedicate to maintiaining this project as well as my other active open source projects. Thank you for your understanding. + +--- + I am working on a large-scale AngularJS-based project and I'll be extracting any useful re-usable components that I make and putting them here. @@ -33,4 +38,4 @@ This code is made available under the MIT license, so feel free to use any of th ## License -MIT \ No newline at end of file +MIT From 9a093e0bc76238b6e4b7a84adbf5d2572fa028be Mon Sep 17 00:00:00 2001 From: Michael Bromley Date: Thu, 20 Apr 2017 09:31:48 +0200 Subject: [PATCH 4/5] Add no longer maintained notices in readmes --- src/directives/disqus/README.md | 6 ++++++ src/directives/pagination/README.md | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/src/directives/disqus/README.md b/src/directives/disqus/README.md index 7897599..e386a83 100644 --- a/src/directives/disqus/README.md +++ b/src/directives/disqus/README.md @@ -1,5 +1,11 @@ # Disqus Directive +### No longer maintained +(20/04/2017) - I am no longer actively maintaining this project. I no longer use AngularJS in my own projects and do not have the time to dedicate to maintiaining this project as well as my other active open source projects. Thank you for your understanding. + +--- + + A directive to embed a Disqus comments widget on your AngularJS page. ## Prerequisites diff --git a/src/directives/pagination/README.md b/src/directives/pagination/README.md index 429d6a0..990067e 100644 --- a/src/directives/pagination/README.md +++ b/src/directives/pagination/README.md @@ -1,5 +1,10 @@ # Pagination Directive +### No longer maintained +(20/04/2017) - I am no longer actively maintaining this project. I no longer use AngularJS in my own projects and do not have the time to dedicate to maintiaining this project as well as my other active open source projects. Thank you for your understanding. + +--- + ## Another one? Yes, there are quite a few pagination solutions for Angular out there already, but what I wanted to do was make From 75dd112ff7b71b32f08743c2d0f29434f12dfa5c Mon Sep 17 00:00:00 2001 From: Michael Bromley Date: Tue, 27 Jun 2017 12:54:54 +0200 Subject: [PATCH 5/5] add license --- src/directives/pagination/README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/directives/pagination/README.md b/src/directives/pagination/README.md index 990067e..4fd209f 100644 --- a/src/directives/pagination/README.md +++ b/src/directives/pagination/README.md @@ -440,3 +440,7 @@ from their pagination directive. from the various contributors to this thread. * Massive credit is due to all the [contributors](https://github.com/michaelbromley/angularUtils/graphs/contributors) to this project - they have brought improvements that I would not have the time or insight to figure out myself. + +## License + +MIT