Improve reset password logic

Author: summerblue

app/Http/Controllers/UsersController.php

@@ -56,7 +56,7 @@ public function store(Request $request)
         $user = User::create([
             'name' => $request->name,
             'email' => $request->email,
-            'password' => $request->password,
+            'password' => bcrypt($request->password),
         ]);
 
         $this->sendEmailConfirmationTo($user);
@@ -81,10 +81,11 @@ public function update($id, Request $request)
         $user = User::findOrFail($id);
         $this->authorize('update', $user);
 
-        $data = array_filter([
-            'name' => $request->name,
-            'password' => $request->password,
-        ]);
+        $data = [];
+        $data['name'] = $request->name;
+        if ($request->password) {
+            $data['password'] = bcrypt($request->password);
+        }
         $user->update($data);
 
         session()->flash('success', '个人资料更新成功！');

app/Models/User.php

@@ -54,11 +54,6 @@ public function gravatar($size = '100')
         return "http://www.gravatar.com/avatar/$hash?s=$size";
     }
 
-    public function setPasswordAttribute($password)
-    {
-        $this->attributes['password'] = bcrypt($password);
-    }
-
     public function statuses()
     {
         return $this->hasMany(Status::class);

database/seeds/UsersTableSeeder.php

@@ -18,7 +18,7 @@ public function run()
         $user = User::find(1);
         $user->name = 'Aufree';
         $user->email = '[email protected]';
-        $user->password = 'password';
+        $user->password = bcrypt('password');
         $user->is_admin = true;
         $user->activated = true;
         $user->save();