Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: henrysher/cob
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: gitadup/cob
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 15, 2022

  1. Fix for changes in urlsplit 

    urlsplit function was changed to strip ASCII newline and tab characters
in python/cpython#25595.

The change causes this plugin to not properly authenticate with S3, since
a required newline character is no longer present.

This issue was identified on Amazon Linux 2 Python distribution which
backported the change to Python 2.
https://alas.aws.amazon.com/AL2/ALAS-2022-1802.html.

urlsplit behaviour before the fix.
```
Python 2.7.18 (default, Jun 10 2021, 00:11:02)
[GCC 7.3.1 20180712 (Red Hat 7.3.1-13)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from urlparse import urlsplit
>>> urlsplit("http://localhost/some-path/n").path
'/some-path\n'
>>>
```

urlsplit behaviour after the fix.
```
Python 2.7.18 (default, May 25 2022, 14:30:51)
[GCC 7.3.1 20180712 (Red Hat 7.3.1-15)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from urlparse import urlsplit
>>> urlsplit("http://localhost/some-path/n").path
'/some-path'
>>>
```
    @PhilGrayson
    PhilGrayson committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    fafc141 View commit details
    Browse the repository at this point in the history
Loading