MYCPP-311: Fix Seg Fault when passing NULL to mysqlx_set_view_definer

Author: silvakid

xapi/tests/xapi-t.cc

@@ -66,6 +66,7 @@ TEST_F(xapi, view_ddl_test)
   EXPECT_EQ(RESULT_OK, mysqlx_set_view_algorithm(vstmt, VIEW_ALGORITHM_MERGE));
   EXPECT_EQ(RESULT_OK, mysqlx_set_view_security(vstmt, VIEW_SECURITY_INVOKER));
   EXPECT_EQ(RESULT_OK, mysqlx_set_view_check_option(vstmt, VIEW_CHECK_OPTION_CASCADED));
+  EXPECT_EQ(RESULT_OK, mysqlx_set_view_definer(vstmt, NULL));
   EXPECT_EQ(RESULT_OK, mysqlx_set_view_definer(vstmt, "root"));
 
   // Change parent SELECT STMT, it is not supposed to affect the VIEW STMT in any way

xapi/view.cc

@@ -99,8 +99,15 @@ void View_spec::set_check(int val)
 
 void View_spec::set_definer(const char* val)
 {
-  m_opts.m_definer_set = true;
-  m_opts.m_definer = val;
+  if (val)
+  {
+    m_opts.m_definer_set = true;
+    m_opts.m_definer = val;
+  }
+  else
+  { // If definer = NULL, we will not report it
+    m_opts.m_definer_set = false;
+  }
 }
 
 void View_spec::set_columns(va_list args)
@@ -138,4 +145,4 @@ void View_spec::View_opts::process(Processor &prc) const
 
   if (m_definer_set)
     prc.definer(m_definer);
-}
+}