Skip to content

Commit 0e7ce1f

Browse files
authored
Merge pull request #38088 from github/repo-sync
Repo sync
2 parents 41691d3 + d6dfa5c commit 0e7ce1f

File tree

8 files changed

+72
-3
lines changed

8 files changed

+72
-3
lines changed

content/admin/managing-iam/using-saml-for-enterprise-iam/troubleshooting-saml-authentication.md

+8
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,14 @@ Ensure that you set the value for `Audience` on your IdP to the `EntityId` for {
9999

100100
{% data reusables.saml.current-time-earlier-than-notbefore-condition %}
101101

102+
{% ifversion ghes > 3.16 %}
103+
104+
## Error: "failure - Updated SAML validation returned an invalid result"
105+
106+
This error can occur in version 3.17.0 or later of {% data variables.location.product_location %}. It indicates that {% data variables.product.github %} is unable to properly process the SAML response it received from the identity provider. Please open a {% data variables.product.github %} support ticket so that the {% data variables.product.github %} Support and Engineering teams can investigate and address the issue.
107+
108+
{% endif %}
109+
102110
{% ifversion ghec %}
103111
{% data reusables.saml.authentication-loop %}
104112
{% endif %}

src/events/components/experiments/experiments.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const EXPERIMENTS = {
2121
ai_search_experiment: {
2222
key: 'ai_search_experiment',
2323
isActive: true, // Set to false when the experiment is over
24-
percentOfUsersToGetExperiment: 0, // 10% of users will get the experiment
24+
percentOfUsersToGetExperiment: 1, // 10% of users will get the experiment
2525
includeVariationInContext: true, // All events will include the `experiment_variation` of the `ai_search_experiment`
2626
limitToLanguages: ['en'], // Only users with the `en` language will be included in the experiment
2727
alwaysShowForStaff: true, // When set to true, staff will always see the experiment (determined by the `staffonly` cookie)

src/graphql/data/fpt/changelog.json

+13
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,17 @@
11
[
2+
{
3+
"schemaChanges": [
4+
{
5+
"title": "The GraphQL schema includes these changes:",
6+
"changes": [
7+
"<p>Type <code>BotOrUser</code> was added</p>"
8+
]
9+
}
10+
],
11+
"previewChanges": [],
12+
"upcomingChanges": [],
13+
"date": "2025-05-06"
14+
},
215
{
316
"schemaChanges": [
417
{

src/graphql/data/fpt/schema.docs.graphql

+5
Original file line numberDiff line numberDiff line change
@@ -2413,6 +2413,11 @@ type Bot implements Actor & Node & UniformResourceLocatable {
24132413
url: URI!
24142414
}
24152415

2416+
"""
2417+
Used when either Bot or User are accepted.
2418+
"""
2419+
union BotOrUser = Bot | User
2420+
24162421
"""
24172422
Types which can be actors for `BranchActorAllowance` objects.
24182423
"""

src/graphql/data/fpt/schema.json

+19
Original file line numberDiff line numberDiff line change
@@ -94718,6 +94718,25 @@
9471894718
}
9471994719
]
9472094720
},
94721+
{
94722+
"name": "BotOrUser",
94723+
"kind": "unions",
94724+
"id": "botoruser",
94725+
"href": "/graphql/reference/unions#botoruser",
94726+
"description": "<p>Used when either Bot or User are accepted.</p>",
94727+
"possibleTypes": [
94728+
{
94729+
"name": "Bot",
94730+
"id": "bot",
94731+
"href": "/graphql/reference/objects#bot"
94732+
},
94733+
{
94734+
"name": "User",
94735+
"id": "user",
94736+
"href": "/graphql/reference/objects#user"
94737+
}
94738+
]
94739+
},
9472194740
{
9472294741
"name": "BranchActorAllowanceActor",
9472394742
"kind": "unions",

src/graphql/data/ghec/schema.docs.graphql

+5
Original file line numberDiff line numberDiff line change
@@ -2413,6 +2413,11 @@ type Bot implements Actor & Node & UniformResourceLocatable {
24132413
url: URI!
24142414
}
24152415

2416+
"""
2417+
Used when either Bot or User are accepted.
2418+
"""
2419+
union BotOrUser = Bot | User
2420+
24162421
"""
24172422
Types which can be actors for `BranchActorAllowance` objects.
24182423
"""

src/graphql/data/ghec/schema.json

+19
Original file line numberDiff line numberDiff line change
@@ -94718,6 +94718,25 @@
9471894718
}
9471994719
]
9472094720
},
94721+
{
94722+
"name": "BotOrUser",
94723+
"kind": "unions",
94724+
"id": "botoruser",
94725+
"href": "/graphql/reference/unions#botoruser",
94726+
"description": "<p>Used when either Bot or User are accepted.</p>",
94727+
"possibleTypes": [
94728+
{
94729+
"name": "Bot",
94730+
"id": "bot",
94731+
"href": "/graphql/reference/objects#bot"
94732+
},
94733+
{
94734+
"name": "User",
94735+
"id": "user",
94736+
"href": "/graphql/reference/objects#user"
94737+
}
94738+
]
94739+
},
9472194740
{
9472294741
"name": "BranchActorAllowanceActor",
9472394742
"kind": "unions",

src/search/components/input/SearchOverlay.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -794,8 +794,8 @@ export function SearchOverlay({
794794
// Hubbers users use an internal discussion for feedback
795795
window.open('https://github.com/github/docs-team/discussions/5172', '_blank')
796796
} else {
797-
// TODO: On ship date set this value
798-
// window.open('TODO', '_blank')
797+
// public discussion for feedback
798+
window.open('https://github.com/orgs/community/discussions/158488', '_blank')
799799
}
800800
}}
801801
as="button"

0 commit comments

Comments
 (0)