Improve directory creation

Author: sebastianbergmann

src/Report/Clover.php

@@ -235,7 +235,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
         $buffer = $xmlDocument->saveXML();
 
         if ($target !== null) {
-            if (!@\mkdir(\dirname($target), 0777, true) && !\is_dir(\dirname($target))) {
+            if (!$this->createDirectory(\dirname($target))) {
                 throw new \RuntimeException(\sprintf('Directory "%s" was not created', \dirname($target)));
             }
 
@@ -251,4 +251,9 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
 
         return $buffer;
     }
+
+    private function createDirectory(string $directory): bool
+    {
+        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
+    }
 }

src/Report/Crap4j.php

@@ -117,7 +117,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
         $buffer = $document->saveXML();
 
         if ($target !== null) {
-            if (!@\mkdir(\dirname($target), 0777, true) && !\is_dir(\dirname($target))) {
+            if (!$this->createDirectory(\dirname($target))) {
                 throw new \RuntimeException(\sprintf('Directory "%s" was not created', \dirname($target)));
             }
 
@@ -162,4 +162,9 @@ private function roundValue($value): float
     {
         return \round($value, 2);
     }
+
+    private function createDirectory(string $directory): bool
+    {
+        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
+    }
 }

src/Report/Html/Facade.php

@@ -94,7 +94,7 @@ public function process(CodeCoverage $coverage, string $target): void
             $id = $node->getId();
 
             if ($node instanceof DirectoryNode) {
-                if (!@\mkdir($target . $id, 0777, true) && !\is_dir($target . $id)) {
+                if (!$this->createDirectory($target . $id)) {
                     throw new \RuntimeException(\sprintf('Directory "%s" was not created', $target . $id));
                 }
 
@@ -103,7 +103,7 @@ public function process(CodeCoverage $coverage, string $target): void
             } else {
                 $dir = \dirname($target . $id);
 
-                if (!@\mkdir($dir, 0777, true) && !\is_dir($dir)) {
+                if (!$this->createDirectory($dir)) {
                     throw new \RuntimeException(\sprintf('Directory "%s" was not created', $dir));
                 }
 
@@ -161,7 +161,7 @@ private function getDirectory(string $directory): string
             $directory .= DIRECTORY_SEPARATOR;
         }
 
-        if (!@\mkdir($directory, 0777, true) && !\is_dir($directory)) {
+        if (!$this->createDirectory($directory)) {
             throw new RuntimeException(
                 \sprintf(
                     'Directory "%s" does not exist.',
@@ -172,4 +172,9 @@ private function getDirectory(string $directory): string
 
         return $directory;
     }
+
+    private function createDirectory(string $directory): bool
+    {
+        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
+    }
 }

src/Report/Xml/Facade.php

@@ -90,7 +90,7 @@ private function initTargetDirectory(string $directory): void
                     "'$directory' exists but is not writable."
                 );
             }
-        } elseif (!@\mkdir($directory, 0777, true)) {
+        } elseif (!$this->createDirectory($directory)) {
             throw new RuntimeException(
                 "'$directory' could not be created."
             );
@@ -280,4 +280,9 @@ private function saveDocument(\DOMDocument $document, string $name): void
 
         $document->save($filename);
     }
+
+    private function createDirectory(string $directory): bool
+    {
+        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
+    }
 }