Skip to content

Commit 7582b19

Browse files
committed
Start share intent without chooser
This is to be consistent with other share actions in the app. Also use the repository id as the subject instead of just the name.
1 parent 87eb341 commit 7582b19

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

app/res/values/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@
234234
<string name="starring_repository">Starring…</string>
235235
<string name="unstarring_repository">Unstarring…</string>
236236
<string name="navigate_to">Navigate to…</string>
237-
<string name="share_repo">Share this Repo!</string>
238237

239238
<!-- Tab titles, should be as short as possible -->
240239
<string name="tab_repositories">repositories</string>

app/src/main/java/com/github/mobile/ui/repo/RepositoryViewActivity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -276,8 +276,8 @@ protected void onSuccess(Boolean watching) throws Exception {
276276
}
277277

278278
private void shareRepositoryURL() {
279-
Intent sharingIntent = ShareUtils.create(repository.getName(), repository.getHtmlUrl());
280-
startActivity(Intent.createChooser(sharingIntent, getResources()
281-
.getText(string.share_repo)));
279+
Intent sharingIntent = ShareUtils.create(repository.generateId(),
280+
repository.getHtmlUrl());
281+
startActivity(sharingIntent);
282282
}
283283
}

0 commit comments

Comments
 (0)