Skip to content

modules/auth/password/hash tests are slow #24539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
silverwind opened this issue May 5, 2023 · 2 comments
Closed

modules/auth/password/hash tests are slow #24539

silverwind opened this issue May 5, 2023 · 2 comments
Labels
type/testing

Comments

@silverwind
Copy link
Member

silverwind commented May 5, 2023 •
edited
Loading

From https://github.com/go-gitea/gitea/actions/runs/4888003655/jobs/8725237392:

✓  modules/auth/password/hash (1m51.007s)

Almost two minutes for this seems far too slow.
@silverwind silverwind added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/testing and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels May 5, 2023
@lunny
Copy link
Member

lunny commented May 5, 2023

scrypt spent 10x times than other algorithm.

@wxiaoguang
Copy link
Contributor

It should have been fixed by SetDefaultPasswordHashAlgorithm("dummy") now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @silverwind @wxiaoguang