x/tools/tools/internal/tokeninternal/tokeninternal_go125.go: fset.AddExistingFiles undefined

[xieyuschen]

gopls version

golang.org/x/tools/gopls v0.18.1

go env

AR='ar'
CC='gcc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='0'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='g++'
GCCGO='gccgo'
GO111MODULE=''
GOAMD64='v1'
GOARCH='amd64'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/home/xieyuschen/.cache/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/home/xieyuschen/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1290695935=/tmp/go-build -gno-record-gcc-switches'
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMOD='/home/xieyuschen/codespace/tools/gopls/go.mod'
GOMODCACHE='/home/xieyuschen/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/xieyuschen/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/xieyuschen/.config/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.24.2'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

Checkout to tools@master, d3809eaa2, then click hovered test for function TestFixPhantomSelector inside `gopls/internal/cache/parsego/parse_test.go.

What did you see happen?

Running tool: /home/xieyuschen/codespace/go/bin/go test -timeout 30s -run ^TestFixPhantomSelector$ golang.org/x/tools/gopls/internal/cache/parsego

# golang.org/x/tools/internal/tokeninternal
/home/xieyuschen/codespace/tools/internal/tokeninternal/tokeninternal_go125.go:15:7: fset.AddExistingFiles undefined (type *token.FileSet has no field or method AddExistingFiles)
FAIL	golang.org/x/tools/gopls/internal/cache/parsego [build failed]
FAIL

What did you expect to see?

I expected it won't fail due to build error. If I copy the command in output and run in my shell, it succeeds.

go test -timeout 30s -run ^TestFixPhantomSelector$ golang.org/x/tools/gopls/internal/cache/parsego

Editor and settings

No response

Logs

No response

[adonovan]

This function was recently added to the go/token package, so you'll need to sync to a newer go1.25 standard library.

[xieyuschen]

Get it and apologize the carelessness, I noticed that my vscode uses go1.25 built from source rather than the global go1.24.2.
thanks