This is an automated CL which updates the codereview.cfg.

For golang/go#70301

Change-Id: I4ec94b5070c9e34c631a5112700292edf825f7b9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/626656
Auto-Submit: Gopher Robot <[email protected]>
Reviewed-by: Hongxiang Jiang <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: I4d9ef00c940ee1f4f7591b6331629a6f5ab2c3a1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/626657
Reviewed-by: Hongxiang Jiang <[email protected]>
Auto-Submit: Gopher Robot <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Robert Findley <[email protected]>

Merge List:

+ 2024-11-14 5b5d57c gopls/codeaction: fix panic when removing unused parameters with syntax errors.
+ 2024-11-13 025b812 gopls/internal/server: don't call window/showDocument if unsupported
+ 2024-11-13 288b9cb gopls/internal/golang: add missing imports in foo_test.go
+ 2024-11-13 87ac91f gopls/internal/server: revert the gopls.run_govulncheck command
+ 2024-11-12 c531f1b gopls/internal/golang: avoid crash in hover on field of non-struct
+ 2024-11-12 a37eeb4 README: mention the git repo
+ 2024-11-12 8dd84a4 go/ssa/interp: assign phi nodes in parallel

For golang/go#70301

Change-Id: I9b584de0bcbd622a6bcf5f06f34232993ac2f9a4

This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: Ibf9b0ab5ac4be19833c364722297b73a72273ebb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/628035
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Gopher Robot <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Reviewed-by: Hongxiang Jiang <[email protected]>

Also add back the x/tools replace directive.

For golang/go#70301

Merge List:

+ 2024-11-26 68e4702 go/analysis/passes/printf: add missing call to Func.Origin
+ 2024-11-26 30a3bd9 gopls/internal/golang: refactor.extract.variable: allow all exprs
+ 2024-11-26 0edd1ab gopls/internal/cache/methodsets: refine crash for missing object path
+ 2024-11-25 07a58bc gopls/internal/golang: refine crash golang/go#70553
+ 2024-11-25 c622026 completions/inference: infer polymorphic types in completions
+ 2024-11-25 dcfb0b6 gopls/internal/golang: change signature via renaming 'func'
+ 2024-11-25 bfcbc1b internal/refactor/inline: avoid unnecessary desugaring in selectors
+ 2024-11-25 b93a72a internal/refactor/inline: fix spurious caller mutation
+ 2024-11-25 41f04a0 internal/refactor/inline: fix comment movement due to added imports
+ 2024-11-25 0841661 internal/refactor/inline: avoid unnecessary interface conversions
+ 2024-11-25 68b67b4 gopls/internal/golang: support parameter movement refactorings
+ 2024-11-22 51e54e8 gopls/doc/features: enable and document source.addTest code action
+ 2024-11-22 458067f gopls/internal/golang: improve test package name selection for new file
+ 2024-11-22 68caf84 gopls/internal/golang: don't lose ... when split/joining variadics
+ 2024-11-21 1e0d4ee go/analysis/checker: disable Example on wasm
+ 2024-11-21 8b6e84b gopls/internal/crash: don't crash in xrefs on out of bound nodes
+ 2024-11-21 936a401 gopls/internal/golang: preserve copyright and build constraint
+ 2024-11-21 1ffc3a1 gopls/internal/test/marker: add defloc, to bind positions by definition
+ 2024-11-21 442d6be gopls/internal/test/marker: document named parameters
+ 2024-11-21 ae39b13 go/analysis/checker: a go/packages-based driver library
+ 2024-11-21 c3a6283 go/packages: undeprecate Load* style flags
+ 2024-11-20 9dff42e gopls/internal/golang/extract: preserve comments in extracted block
+ 2024-11-20 8c3ba8c internal/refactor: undo variadic elimination during substitution
+ 2024-11-20 3b0b264 internal/refactor: handle qualified names in inlined assignments
+ 2024-11-20 9311800 gopls/internal/test/marker: ignore diags in fixedbugs/issue59944.txt
+ 2024-11-20 c1aa79d gopls/internal/golang: fix gopls hover doc link
+ 2024-11-20 e751756 internal/analysisinternal: unify zero value function to typesinternal
+ 2024-11-20 a287481 internal/imports: test Source for go mod cache
+ 2024-11-19 9387a39 gopls/doc/contributing.md: update expectations
+ 2024-11-19 e08fcf7 gopls/internal/analysis/undeclaredname: merge into CodeAction
+ 2024-11-18 0c01408 internal/refactor/inline: avoid binding decl for name used by other args
+ 2024-11-18 63e03c3 gopls/internal/test/marker: generalize codeaction with named args
+ 2024-11-18 acc2a74 go/analysis/passes/copylock: enable unfortunate tests
+ 2024-11-18 39cb6f0 internal/facts: use alias type parameters and arguments during imports
+ 2024-11-18 9b9871d go/analysis/passes/copylock: test for noCopy for sync Map, Mutex, Once
+ 2024-11-18 a54bd37 gopls/internal/golang: don't try to inline dynamic calls
+ 2024-11-18 52eb446 internal/imports: adjust TestStdlibSelfImports pkg
+ 2024-11-18 b8ff201 gopls/internal/cache: refine bug reports for inconsistent dep view
+ 2024-11-18 e59fd36 go/ssa: use ZeroString unconditionally
+ 2024-11-18 60bc93d gopls/internal/cache: fix handling of cgo standalone files
+ 2024-11-18 ed19fc7 gopls/internal/test: synchronize notifications during commands
+ 2024-11-15 254baba gopls/internal/cache: failure to extract diagnostic fixes is an error
+ 2024-11-15 56ec111 gopls/internal/server: remove spurious Async in legacy RunGoVulncheck
+ 2024-11-14 b1c39aa gopls/internal/cache: use a named bool type for allowNetwork
+ 2024-11-14 c043599 gopls/internal/protocol: add DocumentURI.DirPath
+ 2024-11-14 29f4edb gopls/internal/cache: simplify usage of snapshot.GoCommandInvocation
+ 2024-11-14 3c20e3f gopls/internal/analysis/yield: analyzer for iterator (yield) mistakes
+ 2024-11-14 221e94d gopls/internal/cache: id command-line-arguments packages using GoFiles
+ 2024-11-14 84e9c33 gopls/internal/golang: more idiomatic result naming in extract
+ 2024-11-14 8bb5da3 gopls/internal/golang: special handling for input context.Context
+ 2024-11-14 b4332e0 gopls/internal/golang, go/ssa: remove unnamed input parameter
+ 2024-11-14 a8d0fa5 go/packages: call testenv.NeedsGoPackages for TestDirAndForTest
+ 2024-11-14 47a5f7d gopls/internal/golang: fix bad slice append in function extraction

Change-Id: I2abfc8fd925da3b4ee5964e1cf32bb7fada0e688

This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: I0d9836a99dc7a922c605a62f66ae73bcebffa1ed
Reviewed-on: https://go-review.googlesource.com/c/tools/+/631857
Reviewed-by: Robert Findley <[email protected]>
Reviewed-by: Hongxiang Jiang <[email protected]>
Auto-Submit: Gopher Robot <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Also add back the x/tools replace directive for gopls.

For golang/go#70301

Merge List:

+ 2024-12-04 7eebab3 gopls/internal/golang: support extract variable at top level
+ 2024-12-04 e334696 gopls/internal/golang: ignore effects for change signature refactoring
+ 2024-12-04 3901733 internal/refactor/inline: substitute groups of dependent arguments
+ 2024-12-03 61b2408 gopls/internal/golang: add "Extract constant" counterpart
+ 2024-12-03 c01eead internal/gcimporter: require binary export data header
+ 2024-12-03 9a04136 gopls/internal/golang/stubmethods: refine crash into bug report
+ 2024-12-03 01e0b05 internal/refactor/inline: fix condition for splice assignment strategy
+ 2024-12-03 557f540 gopls/internal/golang: don't offer to move variadic parameters
+ 2024-12-03 399ee16 internal/gcimporter: update FindExportData to return a non-negative size
+ 2024-12-03 25b0003 internal/refactor/inline: more precise redundant conversion detection
+ 2024-12-03 eb46939 gopls/internal/test/marker: add reproducers for moveparam bug bash bugs
+ 2024-12-03 4296223 gopls/internal/analysis/yield: add comment about dataflow
+ 2024-12-03 7a4f3b0 internal/gcimporter: require archive files
+ 2024-12-02 2f73c61 gopls/internal/golang: avoid crash in lookupDocLinkSymbol
+ 2024-12-02 ef3d603 gopls/internal/golang/completion: fix crash with extra results
+ 2024-12-02 8ffeaba gopls/internal/settings: enable 'waitgroup' analyzer
+ 2024-12-02 4317959 go/analysis/passes/waitgroup: report WaitGroup.Add in goroutine
+ 2024-12-02 72fdfa6 gopls/internal/golang: Disable test generation for generic functions
+ 2024-12-02 b80f1ed gopls/internal/analysis/yield: peephole-optimize phi(false, x)
+ 2024-11-28 e7bd227 gopls/internal/golang: fix folding range for function calls
+ 2024-11-28 e71702b internal/versions: remove constraint.GoVersion wrapper
+ 2024-11-28 c99edec gopls/internal/golang/completion: add alias support for literals
+ 2024-11-27 bfe3046 go/packages: add a unit test for golang/go#70394
+ 2024-11-27 df87831 gopls/internal/undeclaredname: add missing colon when appropriate
+ 2024-11-26 53efd30 gopls/internal/golang: simplify package name collection in add test

Change-Id: I476e80493f61732701784befe2b130ca967b259e

This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: Ib85bc49e388697ea643a0512e877225e48d67714
Reviewed-on: https://go-review.googlesource.com/c/tools/+/633915
Reviewed-by: Robert Findley <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Auto-Submit: Gopher Robot <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

…Value,Expr} for gopls

In CL 626537, the gopls behavior of formatting or generating a type
expression for the zero value of a types.Type was changed to panic in
the presence of invalid types. This leads to multiple panics in gopls
(see tests). Fix by selectively rolling back this aspect of the change,
as it relates to gopls.

Also, add back the replace directive for the release branch.

Fixes golang/go#70744

Change-Id: Ife9ae9a0fedf5a9d6b321cfb959f0d16eeec2986
Reviewed-on: https://go-review.googlesource.com/c/tools/+/634923
Reviewed-by: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit 82b6f75)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/635215

This is an automated CL which updates the go.mod and go.sum.

For golang/go#70301

Change-Id: I2dc875c08d637f182583c663072ce11ad8230420
Reviewed-on: https://go-review.googlesource.com/c/tools/+/635235
Auto-Submit: Gopher Robot <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

…sh in instance conversion

The new inference logic assumed that a CallExpr surrounding an instance
was a function, but it could be a conversion, builtin, or invalid type.
Add the missing check.

Fixes golang/go#70889

Change-Id: I0b05a90cca671196cf5cfd8782b6863e17485cc1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/637635
Reviewed-by: Alan Donovan <[email protected]>
Auto-Submit: Robert Findley <[email protected]>
Commit-Queue: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit 74dea82)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/637675

… with *error argument

The test detection logic incorrectly assumes that named types have a
non-nil package, which is not true for Error (as we've encountered
numerous times). Add the missing nil check.

Fixes golang/go#70927

Change-Id: Ibdf483304b53ce219123e820d74acd4f9d12d710
Reviewed-on: https://go-review.googlesource.com/c/tools/+/637815
Reviewed-by: Alan Donovan <[email protected]>
Auto-Submit: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit dcc725c)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/637736

This is an automated CL which updates the go.mod and go.sum.

For golang/go#70931

Change-Id: I34c2f27f483baafb5894cf023daa885dcc0faec2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/637835
Reviewed-by: Alan Donovan <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Auto-Submit: Gopher Robot <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>