Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: golang/tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: internal-branch.go1.24-vendor
Choose a head ref
  • 1 commit
  • 7 files changed
  • 1 contributor

Commits on Jan 31, 2025

  1. [internal-branch.go1.24-vendor] go/analysis/passes/printf: suppress e… 

    …rrors for non-const format strings

The new check added in golang/go#60529 reports errors for non-constant
format strings with no arguments. These are almost always bugs, but are
often mild or inconsequential, and can be numerous in existing code
bases.

To reduce friction from this change, gate the new check on the implied
language version.

For golang/go#71485

Change-Id: I4926da2809dd14ba70ae530cd1657119f5377ad5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/645595
Reviewed-by: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Robert Findley <[email protected]>
(cherry picked from commit 9f450b0)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/645697
    @findleyr @cagedmantis
    findleyr authored and cagedmantis committed Jan 31, 2025
    Configuration menu
    Copy the full SHA
    9874647 View commit details
    Browse the repository at this point in the history
Loading