do not use await if not needed

Author: brean

unity-project/Assets/Moulin/DDP/ddp/DdpConnection.cs

@@ -151,18 +151,17 @@ public DdpConnection(string url) {
 			ws.OnMessage += OnWebSocketMessage;
         }
 
-        private async void OnWebSocketOpen()
+        public void OnWebSocketOpen()
         {
             OnDebugMessage?.Invoke("Websocket open");
-            await SendAsync(GetConnectMessage());
-
+            Send(GetConnectMessage());
             foreach (Subscription subscription in subscriptions.Values)
             {
-                await SendAsync(GetSubscriptionMessage(subscription));
+                Send(GetSubscriptionMessage(subscription));
             }
             foreach (MethodCall methodCall in methodCalls.Values)
             {
-                await SendAsync(GetMethodCallMessage(methodCall));
+                Send(GetMethodCallMessage(methodCall));
             }
         }
 
@@ -188,13 +187,13 @@ private void OnWebSocketClose(bool wasClean) {
 		}
 
         // TODO: return Task instead of void
-		private async void OnWebSocketMessage(string data) {
+		private void OnWebSocketMessage(string data) {
 			if (logMessages) OnDebugMessage?.Invoke("OnMessage: " + data);
 			JSONObject message = new JSONObject(data);
-            await HandleMessage(message);
+            HandleMessage(message);
 		}
 
-		private async Task HandleMessage(JSONObject message) {
+		private void HandleMessage(JSONObject message) {
 			if (!message.HasField(Field.MSG)) {
 				// Silently ignore those messages.
 				return;
@@ -215,16 +214,16 @@ private async Task HandleMessage(JSONObject message) {
                         reason = "The server is using an unsupported DDP protocol version: " +
                         message[Field.VERSION]
                     });
-                    await CloseAsync();
+                    Close();
 					break;
 				}
 
 			    case MessageType.PING: {
 					if (message.HasField(Field.ID)) {
-						await SendAsync(GetPongMessage(message[Field.ID].str));
+						Send(GetPongMessage(message[Field.ID].str));
 					}
 					else {
-                        await SendAsync(GetPongMessage());
+                        Send(GetPongMessage());
 					}
 					break;
 				}
@@ -462,9 +461,10 @@ void Dispose() {
 		}
 
         // send message without waiting for its result
-        async void Send(string message)
+        void Send(string message)
         {
-            await SendAsync(message);
+            Task t = SendAsync(message);
+            t.Wait();
         }
 
         public Subscription Subscribe(string name, params JSONObject[] items)