From 6891155847465887cfe54cba85d357b19472520d Mon Sep 17 00:00:00 2001 From: Kuba Sekowski Date: Wed, 10 Apr 2024 12:18:45 +0200 Subject: [PATCH 1/4] Improve the typing for the angular demo --- angular-demo/src/app/app-button/app-button.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/angular-demo/src/app/app-button/app-button.component.ts b/angular-demo/src/app/app-button/app-button.component.ts index 5fcaac9..26516fe 100644 --- a/angular-demo/src/app/app-button/app-button.component.ts +++ b/angular-demo/src/app/app-button/app-button.component.ts @@ -6,6 +6,6 @@ import { Component, Input } from "@angular/core"; styleUrls: ["./app-button.component.scss"] }) export class AppButton { - @Input() outline: boolean; + @Input() outline: boolean = false; @Input() text: string = "test"; } From 9dea688d80b769249405e6a24df85abd6ce44d0f Mon Sep 17 00:00:00 2001 From: Kuba Sekowski Date: Wed, 10 Apr 2024 13:19:44 +0200 Subject: [PATCH 2/4] Remove console logs from the Angular demo --- angular-demo/src/app/hf-actions/hf-actions.component.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/angular-demo/src/app/hf-actions/hf-actions.component.ts b/angular-demo/src/app/hf-actions/hf-actions.component.ts index f72997e..1eeacf6 100644 --- a/angular-demo/src/app/hf-actions/hf-actions.component.ts +++ b/angular-demo/src/app/hf-actions/hf-actions.component.ts @@ -10,12 +10,10 @@ export class HfActionsComponent { constructor(private _employeesService: EmployeesService) {} public handleClickRunCalculations() { - console.log("handleClickRunCalculations"); this._employeesService.calculate(); } public handleClickReset() { - console.log("handleClickReset"); this._employeesService.reset(); } } From f634febb9646f3ec8ed10c56e1902fe8e1cb776d Mon Sep 17 00:00:00 2001 From: Kuba Sekowski Date: Wed, 10 Apr 2024 15:00:04 +0200 Subject: [PATCH 3/4] Test for codesandbox: Undo the last change to the angular demo --- angular-demo/src/app/hf-actions/hf-actions.component.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/angular-demo/src/app/hf-actions/hf-actions.component.ts b/angular-demo/src/app/hf-actions/hf-actions.component.ts index 1eeacf6..f72997e 100644 --- a/angular-demo/src/app/hf-actions/hf-actions.component.ts +++ b/angular-demo/src/app/hf-actions/hf-actions.component.ts @@ -10,10 +10,12 @@ export class HfActionsComponent { constructor(private _employeesService: EmployeesService) {} public handleClickRunCalculations() { + console.log("handleClickRunCalculations"); this._employeesService.calculate(); } public handleClickReset() { + console.log("handleClickReset"); this._employeesService.reset(); } } From 83c7bd2a0e2dcae882659d8cf5503de3a5b2a5d6 Mon Sep 17 00:00:00 2001 From: Kuba Sekowski Date: Tue, 10 Dec 2024 19:09:31 +0100 Subject: [PATCH 4/4] Fix exceljs API usage in the read-excel-file.js script to handle shared formulas (#25) (#26) --- read-excel-file/read-excel-file.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/read-excel-file/read-excel-file.js b/read-excel-file/read-excel-file.js index 57689e4..db205ee 100644 --- a/read-excel-file/read-excel-file.js +++ b/read-excel-file/read-excel-file.js @@ -26,7 +26,7 @@ function convertXlsxWorkbookToJavascriptArrays(workbook) { const rowData = []; row.eachCell((cell) => { - const cellData = cell.value.formula ? `=${cell.value.formula}` : cell.value; + const cellData = cell.formula ? `=${cell.formula}` : cell.value; rowData.push(cellData); });