Skip to content

Commit 63f43d2

Browse files
author
Stewart Miles
committed
Added support for packaging specs of Android libraries.
Fixed googlesamples#174 Bug: 132070893 Change-Id: I28ca9f48ab08e9343d5e4e259f6354b64fee4c45
1 parent 7e51999 commit 63f43d2

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

source/PlayServicesResolver/scripts/download_artifacts.gradle

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -602,11 +602,7 @@ public class PackageSpecifier implements Comparable {
602602
* @returns Colon separated string.
603603
*/
604604
public String getSpecString() {
605-
List<String> components = componentStrings
606-
if (artifactType && artifactType != "srcaar") {
607-
components = components.dropRight(1) + [versionExpression]
608-
}
609-
return components.join(":")
605+
return componentStrings.join(":")
610606
}
611607

612608
/*
@@ -1455,7 +1451,7 @@ def testPackageSpecifierStrings() {
14551451
[[PackageSpecifier.fromString("a-b:c-d:1.2.3@srcaar"),
14561452
["a-b:c-d:1.2.3@srcaar", "a-b:c-d", "a-b.c-d-1.2.3.aar"]],
14571453
[PackageSpecifier.fromString("a-b:c-d:1.2.3@aar"),
1458-
["a-b:c-d:1.2.3", "a-b:c-d", "a-b.c-d-1.2.3.aar"]],
1454+
["a-b:c-d:1.2.3@aar", "a-b:c-d", "a-b.c-d-1.2.3.aar"]],
14591455
[PackageSpecifier.fromString("a-b:c-d:1.2.3"),
14601456
["a-b:c-d:1.2.3", "a-b:c-d", "a-b.c-d-1.2.3"]],
14611457
[PackageSpecifier.fromString("a-b:c-d"),

source/PlayServicesResolver/scripts/download_artifacts_test.gradle

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,16 @@ createTestTask(
274274
"android.arch.core.common-1.0.0.jar\n" +
275275
"com.android.support.support-annotations-26.1.0.jar"])
276276

277+
createTestTask(
278+
"testDownloadAvailableWithCustomPackaging",
279+
"Downloads a single artifact with custom packaging.",
280+
"com.android.support:support-annotations:23.0.1@magic",
281+
["com.android.support.support-annotations-23.0.1.magic":
282+
"com/android/support/support-annotations/23.0.1/" +
283+
"support-annotations-23.0.1.magic"],
284+
["Copied artifacts:\n" +
285+
"com.android.support.support-annotations-23.0.1.magic"])
286+
277287
createTestTask(
278288
"testDownloadAvailableTwice",
279289
"Downloads a single artifact and it's dependencies from maven.",
@@ -342,7 +352,7 @@ createTestTask(
342352
"com.android.support.support-vector-drawable-24.0.0.aar",
343353
"Modified artifacts:\n" +
344354
"com.android.support:appcompat-v7:23.0.0 --> " +
345-
"com.android.support:appcompat-v7:24.0.0"])
355+
"com.android.support:appcompat-v7:24.0.0@aar"])
346356

347357
createTestTask(
348358
"testDownloadSrcAar",
@@ -545,7 +555,7 @@ createTestTask(
545555
"org.test.psr.locked.new-common-1.5.0.aar\n" +
546556
"org.test.psr.locked.output-1.5.0.aar",
547557
"Modified artifacts:\n" +
548-
"org.test.psr.locked:input:1.2.3 --> org.test.psr.locked:input:1.5.0"])
558+
"org.test.psr.locked:input:1.2.3 --> org.test.psr.locked:input:1.5.0@aar"])
549559

550560
createTestTask(
551561
"testVersionLockedAndNonVersionLocked",

0 commit comments

Comments
 (0)