refactor(dart/transform): Correct Dart analyzer warnings

- Fix numerous Dart analyzer warnings we had been ignoring.
- Delete unused `in_progress` dir

Author: Tim Blasi

modules/angular2/pubspec.yaml

@@ -14,6 +14,7 @@ dependencies:
   code_transformers: '^0.2.5'
   dart_style: '^0.1.3'
   html: '^0.12.0'
+  source_span: '^1.0.0'
   stack_trace: '^1.1.1'
 transformers:
   - angular2

modules/angular2/src/dom/html_adapter.dart

@@ -16,6 +16,36 @@ class Html5LibDomAdapter implements DomAdapter {
     'tabindex': 'tabIndex',
   };
 
+  @override
+  getGlobalEventTarget(String target) {
+    throw 'not implemented';
+  }
+
+  @override
+  getTitle() {
+    throw 'not implemented';
+  }
+
+  @override
+  setTitle(String newTitle) {
+    throw 'not implemented';
+  }
+
+  @override
+  String getEventKey(event) {
+    throw 'not implemented';
+  }
+
+  @override
+  void replaceChild(el, newNode, oldNode) {
+    throw 'not implemented';
+  }
+
+  @override
+  dynamic getBoundingClientRect(el) {
+    throw 'not implemented';
+  }
+
   Element parse(String templateHtml) => parser.parse(templateHtml).firstChild;
   query(selector) {
     throw 'not implemented';
@@ -54,7 +84,7 @@ class Html5LibDomAdapter implements DomAdapter {
   String type(node) {
     throw 'not implemented';
   }
-  content(TemplateElement node) {
+  content(node) {
     throw 'not implemented';
   }
 

modules/angular2/src/transform/common/logging.dart

@@ -1,7 +1,9 @@
 library angular2.transform.common.logging;
 
+import 'dart:async';
 import 'package:barback/barback.dart';
 import 'package:code_transformers/messages/build_logger.dart';
+import 'package:source_span/source_span.dart';
 
 BuildLogger _logger;
 
@@ -24,6 +26,11 @@ BuildLogger get logger {
 }
 
 class PrintLogger implements BuildLogger {
+  @override
+  final String detailsUri = '';
+  @override
+  final bool convertErrorsToWarnings = false;
+
   void _printWithPrefix(prefix, msg) => print('$prefix: $msg');
   void info(msg, {AssetId asset, SourceSpan span}) =>
       _printWithPrefix('INFO', msg);
@@ -43,7 +50,7 @@ class PrintLoggerError extends Error {
   final AssetId asset;
   final SourceSpan span;
 
-  PrintLoggerError(message, asset, span);
+  PrintLoggerError(this.message, this.asset, this.span);
 
   @override
   String toString() {

modules/angular2/src/transform/common/names.dart

@@ -3,6 +3,7 @@ library angular2.transform.common.names;
 const SETUP_METHOD_NAME = 'initReflector';
 const REFLECTOR_VAR_NAME = 'reflector';
 const DEPS_EXTENSION = '.ng_deps.dart';
+const REFLECTION_CAPABILITIES_NAME = 'ReflectionCapabilities';
 const REGISTER_TYPE_METHOD_NAME = 'registerType';
 const REGISTER_GETTERS_METHOD_NAME = 'registerGetters';
 const REGISTER_SETTERS_METHOD_NAME = 'registerSetters';

modules/angular2/src/transform/common/options_reader.dart

@@ -1,4 +1,4 @@
-library angular2.transform.common.options;
+library angular2.transform.common.options_reader;
 
 import 'package:barback/barback.dart';
 import 'options.dart';

modules/angular2/src/transform/common/parser.dart

@@ -43,7 +43,7 @@ class Parser {
   Future<List<NgDeps>> _recurse(AssetId id,
       [List<NgDeps> allDeps, Set<AssetId> seen]) async {
     if (seen == null) seen = new Set<AssetId>();
-    if (seen.contains(id)) return;
+    if (seen.contains(id)) return null;
     seen.add(id);
 
     if (allDeps == null) allDeps = [];
@@ -75,7 +75,6 @@ class NgDeps {
 
 class _ParseNgDepsVisitor extends Object with RecursiveAstVisitor<Object> {
   NgDeps ngDeps = null;
-  _RegisteredTypeBuilder current = null;
 
   @override
   Object visitImportDirective(ImportDirective node) {

modules/angular2/src/transform/common/visitor_mixin.dart

@@ -5,10 +5,8 @@ import 'package:dart_style/dart_style.dart';
 
 import 'directive_linker/transformer.dart';
 import 'directive_processor/transformer.dart';
-import 'bind_generator/transformer.dart';
 import 'reflection_remover/transformer.dart';
 import 'common/formatter.dart' as formatter;
-import 'common/names.dart';
 import 'common/options.dart';
 import 'common/options_reader.dart';
 

modules/angular2/src/transform/di_transformer.dart

@@ -17,9 +17,10 @@ Future<String> linkNgDeps(AssetReader reader, AssetId entryPoint) async {
   if (ngDeps == null) return null;
   if (ngDeps.imports.isEmpty) return ngDeps.code;
 
-  var allDeps = ngDeps.imports.toList()..addAll(ngDeps.exports);
-  var depList = await _processNgImports(
-      reader, entryPoint, allDeps.map((node) => node.uri.stringValue));
+  var depUris = <String>[]
+    ..addAll(ngDeps.imports.map((i) => i.uri.stringValue))
+    ..addAll(ngDeps.exports.map((i) => i.uri.stringValue));
+  var depList = await _processNgImports(reader, entryPoint, depUris);
 
   if (depList.isEmpty) return ngDeps.code;
 

modules/angular2/src/transform/directive_linker/linker.dart

@@ -6,7 +6,6 @@ import 'package:angular2/src/transform/common/asset_reader.dart';
 import 'package:angular2/src/transform/common/formatter.dart';
 import 'package:angular2/src/transform/common/logging.dart' as log;
 import 'package:angular2/src/transform/common/names.dart';
-import 'package:angular2/src/transform/common/options.dart';
 import 'package:barback/barback.dart';
 
 import 'linker.dart';