refactor(Lifecycle hooks): move the hooks to their own module (lifecycle_hooks)

BREAKING CHANGE

Lifecycle hooks now live in the `angular2/lifecycle_hooks` module.
They previously lived in the `metadata` module.

Author: vicb

docs/public-docs-package/index.js

@@ -5,6 +5,7 @@ module.exports = new Package('angular-v2-public-docs', [basePackage])
 
 .config(function(readTypeScriptModules) {
   readTypeScriptModules.sourceFiles = [
+    'angular2/lifecycle_hooks.ts',
     'angular2/metadata.ts',
     'angular2/change_detection.ts',
     'angular2/core.ts',

modules/angular2/angular2.ts

@@ -15,3 +15,4 @@ export * from './forms';
 export * from './render';
 export * from './profile';
 export {bootstrap} from 'angular2/src/core/application';
+export * from './lifecycle_hooks';

modules/angular2/angular2_exports.ts

@@ -7,3 +7,4 @@ export * from './forms';
 export * from './render';
 export * from './profile';
 export {bootstrap} from 'angular2/src/core/application';
+export * from './lifecycle_hooks';

modules/angular2/lifecycle_hooks.ts

@@ -0,0 +1,17 @@
+/**
+ * @module
+ * @description
+ * Defines interfaces to be implemented by directives when they need to hook into the change
+ * detection mechanism.
+ */
+
+export {
+  AfterContentInit,
+  AfterContentChecked,
+  AfterViewInit,
+  AfterViewChecked,
+  OnChanges,
+  OnDestroy,
+  OnInit,
+  DoCheck
+} from './src/core/compiler/interfaces';

modules/angular2/metadata.dart

@@ -1,4 +1,3 @@
 library angular2.metadata;
 
 export 'package:angular2/src/core/metadata.dart';
-export 'package:angular2/src/core/compiler/interfaces.dart';

modules/angular2/metadata.ts

@@ -3,10 +3,9 @@
  * @description
  *
  * Annotations provide the additional information that Angular requires in order to run your
- * application. This module
- * contains {@link ComponentMetadata}, {@link DirectiveMetadata}, and {@link ViewMetadata}
- * annotations, as well as
- * the {@link Host} annotation that is used by Angular to resolve dependencies.
+ * application. This module contains {@link ComponentMetadata}, {@link DirectiveMetadata}, and
+ * {@link ViewMetadata} annotations, as well as the {@link Host} annotation that is used by Angular
+ * to resolve dependencies.
  *
  */
 
@@ -48,17 +47,5 @@ export {
   HostListenerMetadata
 } from './src/core/metadata';
 
-export {
-  // todo(vbe): LifecycleHook should not be exposed (fails test.typings)
-  LifecycleHook,
-  AfterContentInit,
-  AfterContentChecked,
-  AfterViewInit,
-  AfterViewChecked,
-  OnChanges,
-  OnDestroy,
-  OnInit,
-  DoCheck
-} from './src/core/compiler/interfaces';
 
 export {Class, ClassDefinition, TypeDecorator} from './src/core/util/decorators';

modules/angular2/src/core/compiler/directive_lifecycle_reflector.dart

@@ -2,7 +2,7 @@ library angular2.src.core.compiler.directive_lifecycle_reflector;
 
 import 'package:angular2/src/core/reflection/reflection.dart';
 
-bool hasLifecycleHook(/*LifecycleHook*/ interface, type) {
+bool hasLifecycleHook(interface, type) {
   if (type is! Type) return false;
 
   return reflector.interfaces(type).contains(interface);

modules/angular2/src/core/compiler/directive_lifecycle_reflector.ts

@@ -1,7 +1,7 @@
 import {Type} from 'angular2/src/core/facade/lang';
 import * as Interfaces from './interfaces';
 
-export function hasLifecycleHook(lcInterface: Interfaces.LifecycleHook, type): boolean {
+export function hasLifecycleHook(lcInterface, type): boolean {
   if (!(type instanceof Type)) return false;
 
   var proto = (<any>type).prototype;

modules/angular2/src/core/compiler/interfaces.ts

@@ -8,10 +8,7 @@ import {StringMap} from 'angular2/src/core/facade/collection';
  * - `AfterContentInit`,
  * - `AfterContentChecked`,
  * - `OnDestroy` (at the very end before destruction)
- *
- * // todo(vicb): describe Dart & TS vs JS
  */
-export interface LifecycleHook {}
 
 /**
  * Notify a directive when any of its bindings have changed.
@@ -41,7 +38,7 @@ export interface LifecycleHook {}
  * }
  *  ```
  */
-export class OnChanges implements LifecycleHook {
+export class OnChanges {
   onChanges(changes: StringMap<string, any>): void {}
 }
 
@@ -63,7 +60,7 @@ export class OnChanges implements LifecycleHook {
  * }
  *  ```
  */
-export class OnInit implements LifecycleHook {
+export class OnInit {
   onInit(): void {}
 }
 
@@ -86,7 +83,7 @@ export class OnInit implements LifecycleHook {
  * }
  *  ```
  */
-export class DoCheck implements LifecycleHook {
+export class DoCheck {
   doCheck(): void {}
 }
 
@@ -104,7 +101,7 @@ export class DoCheck implements LifecycleHook {
  * }
  * ```
  */
-export class OnDestroy implements LifecycleHook {
+export class OnDestroy {
   onDestroy(): void {}
 }
 
@@ -122,7 +119,7 @@ export class OnDestroy implements LifecycleHook {
  * }
  *  ```
  */
-export class AfterContentInit implements LifecycleHook {
+export class AfterContentInit {
   afterContentInit(): void {}
 }
 
@@ -140,7 +137,7 @@ export class AfterContentInit implements LifecycleHook {
  * }
  *  ```
  */
-export class AfterContentChecked implements LifecycleHook {
+export class AfterContentChecked {
   afterContentChecked(): void {}
 }
 
@@ -158,7 +155,7 @@ export class AfterContentChecked implements LifecycleHook {
  * }
  *  ```
  */
-export class AfterViewInit implements LifecycleHook {
+export class AfterViewInit {
   afterViewInit(): void {}
 }
 
@@ -176,6 +173,6 @@ export class AfterViewInit implements LifecycleHook {
  * }
  *  ```
  */
-export class AfterViewChecked implements LifecycleHook {
+export class AfterViewChecked {
   afterViewChecked(): void {}
 }

modules/angular2/src/core/directives/ng_class.ts

@@ -1,5 +1,6 @@
 import {isPresent, isString, StringWrapper, isBlank} from 'angular2/src/core/facade/lang';
-import {Directive, DoCheck, OnDestroy} from 'angular2/metadata';
+import {Directive} from 'angular2/metadata';
+import {DoCheck, OnDestroy} from 'angular2/lifecycle_hooks';
 import {ElementRef} from 'angular2/core';
 import {Renderer} from 'angular2/src/core/render/api';
 import {