Skip to content

Commit 17c244e

Browse files
renu555cdunn2001
renu555
authored andcommitted
Fixing unreachable condition.
if (!isMultiLine) at line 563 suggests that isMultiline is 0 when if takes true branch. So the condition && at line 571 will always be false. Also at line 568 !isMultiline in loop conditional check suggests that it depends only on one condition i.e. index <size because !isMultiline is always true. Hence , it seems logical mistake at line 571 of using && instead of ||
1 parent 8050d8b commit 17c244e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/lib_json/json_writer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ bool StyledWriter::isMultineArray(const Value &value) {
344344
for (int index = 0; index < size && !isMultiLine; ++index) {
345345
writeValue(value[index]);
346346
lineLength += int(childValues_[index].length());
347-
isMultiLine = isMultiLine && hasCommentForValue(value[index]);
347+
isMultiLine = isMultiLine || hasCommentForValue(value[index]);
348348
}
349349
addChildValues_ = false;
350350
isMultiLine = isMultiLine || lineLength >= rightMargin_;
@@ -568,7 +568,7 @@ bool StyledStreamWriter::isMultineArray(const Value &value) {
568568
for (int index = 0; index < size && !isMultiLine; ++index) {
569569
writeValue(value[index]);
570570
lineLength += int(childValues_[index].length());
571-
isMultiLine = isMultiLine && hasCommentForValue(value[index]);
571+
isMultiLine = isMultiLine || hasCommentForValue(value[index]);
572572
}
573573
addChildValues_ = false;
574574
isMultiLine = isMultiLine || lineLength >= rightMargin_;

0 commit comments

Comments
 (0)