Skip to content

Commit 66f9f6e

Browse files
committed
Merge pull request android-async-http#898 from condda/master
Renamed "mFile" (38,08%) to "file" (61,92%)
2 parents c665dd9 + 82a999b commit 66f9f6e

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

library/src/main/java/com/loopj/android/http/FileAsyncHttpResponseHandler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
public abstract class FileAsyncHttpResponseHandler extends AsyncHttpResponseHandler {
3333

34-
protected final File mFile;
34+
protected final File file;
3535
protected final boolean append;
3636
private static final String LOG_TAG = "FileAsyncHttpResponseHandler";
3737

@@ -57,7 +57,7 @@ public FileAsyncHttpResponseHandler(File file, boolean append) {
5757
if (!file.getParentFile().isDirectory()) {
5858
Utils.asserts(file.getParentFile().mkdirs(), "Cannot create parent directories for requested File location");
5959
}
60-
this.mFile = file;
60+
this.file = file;
6161
this.append = append;
6262
}
6363

@@ -68,7 +68,7 @@ public FileAsyncHttpResponseHandler(File file, boolean append) {
6868
*/
6969
public FileAsyncHttpResponseHandler(Context context) {
7070
super();
71-
this.mFile = getTemporaryFile(context);
71+
this.file = getTemporaryFile(context);
7272
this.append = false;
7373
}
7474

@@ -105,8 +105,8 @@ protected File getTemporaryFile(Context context) {
105105
* @return File file in which the response is stored
106106
*/
107107
protected File getTargetFile() {
108-
assert (mFile != null);
109-
return mFile;
108+
assert (file != null);
109+
return file;
110110
}
111111

112112
@Override

library/src/main/java/com/loopj/android/http/RangeFileAsyncHttpResponseHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ protected byte[] getResponseData(HttpEntity entity) throws IOException {
101101
}
102102

103103
public void updateRequestHeaders(HttpUriRequest uriRequest) {
104-
if (mFile.exists() && mFile.canWrite())
105-
current = mFile.length();
104+
if (file.exists() && file.canWrite())
105+
current = file.length();
106106
if (current > 0) {
107107
append = true;
108108
uriRequest.setHeader("Range", "bytes=" + current + "-");

library/src/main/java/com/loopj/android/http/SerializableCookie.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ private void writeObject(ObjectOutputStream out) throws IOException {
6161
}
6262

6363
private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
64-
String name = (String) in.readObject();
64+
String key = (String) in.readObject();
6565
String value = (String) in.readObject();
66-
clientCookie = new BasicClientCookie(name, value);
66+
clientCookie = new BasicClientCookie(key, value);
6767
clientCookie.setComment((String) in.readObject());
6868
clientCookie.setDomain((String) in.readObject());
6969
clientCookie.setExpiryDate((Date) in.readObject());

sample/src/main/java/com/loopj/android/http/sample/PrePostProcessingSample.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ public void run() {
126126

127127
private class PrePostProcessRequest extends AsyncHttpRequest {
128128

129-
public PrePostProcessRequest(AbstractHttpClient client, HttpContext context, HttpUriRequest request, ResponseHandlerInterface responseHandler) {
130-
super(client, context, request, responseHandler);
129+
public PrePostProcessRequest(AbstractHttpClient client, HttpContext httpContext, HttpUriRequest request, ResponseHandlerInterface responseHandler) {
130+
super(client, httpContext, request, responseHandler);
131131
}
132132

133133
@Override

0 commit comments

Comments
 (0)