Drop body when redirecting, close AsyncHttpClient#898

Author: slandelle

src/main/java/com/ning/http/client/providers/netty/handler/Protocol.java

@@ -89,16 +89,16 @@ public Protocol(ChannelManager channelManager, AsyncHttpClientConfig config, Net
 
     private FluentCaseInsensitiveStringsMap propagatedHeaders(Request request, Realm realm, boolean switchToGet) {
 
-        FluentCaseInsensitiveStringsMap originalHeaders = request.getHeaders();
-        originalHeaders.remove(HOST);
-        originalHeaders.remove(CONTENT_LENGTH);
-        if (switchToGet)
-            originalHeaders.remove(CONTENT_TYPE);
+        FluentCaseInsensitiveStringsMap headers = request.getHeaders()//
+                .delete(HttpHeaders.Names.HOST)//
+                .delete(HttpHeaders.Names.CONTENT_LENGTH)//
+                .delete(HttpHeaders.Names.CONTENT_TYPE);
+
         if (realm != null && realm.getScheme() == AuthScheme.NTLM) {
-            originalHeaders.remove(AUTHORIZATION);
-            originalHeaders.remove(PROXY_AUTHORIZATION);
+            headers.delete(AUTHORIZATION)//
+                    .delete(PROXY_AUTHORIZATION);
         }
-        return originalHeaders;
+        return headers;
     }
 
     protected boolean exitAfterHandlingRedirect(//
@@ -122,13 +122,18 @@ protected boolean exitAfterHandlingRedirect(//
                 Uri uri = Uri.create(future.getUri(), location);
 
                 if (!uri.equals(future.getUri())) {
-                    final RequestBuilder requestBuilder = new RequestBuilder(future.getRequest());
-
-                    // if we are to strictly handle 302, we should keep the original method (which browsers don't)
-                    // 303 must force GET
-                    boolean switchToGet = !request.getMethod().equals("GET") && (statusCode == 303 || (statusCode == 302 && !config.isStrict302Handling()));
-                    if (switchToGet)
-                        requestBuilder.setMethod("GET");
+                    String originalMethod = request.getMethod();
+                    boolean switchToGet = !originalMethod.equals("GET") && (statusCode == 303 || (statusCode == 302 && !config.isStrict302Handling()));
+
+                    final RequestBuilder requestBuilder = new RequestBuilder(switchToGet ? "GET" : originalMethod)//
+                            .setConnectionPoolKeyStrategy(request.getConnectionPoolPartitioning())//
+                            .setInetAddress(request.getInetAddress())//
+                            .setLocalInetAddress(request.getLocalAddress())//
+                            .setVirtualHost(request.getVirtualHost())//
+                            .setProxyServer(request.getProxyServer())//
+                            .setRealm(request.getRealm());
+
+                    requestBuilder.setHeaders(propagatedHeaders(request, realm, switchToGet));
 
                     // in case of a redirect from HTTP to HTTPS, future attributes might change
                     final boolean initialConnectionKeepAlive = future.isKeepAlive();